From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Date: Mon, 31 Oct 2016 06:06:58 +0000 Subject: Re: [PATCH 08/15] powerpc/iommu: use permission-specific DEVICE_ATTR variants Message-Id: <87twbt127x.fsf@concordia.ellerman.id.au> List-Id: References: <1477769829-22230-1-git-send-email-Julia.Lawall@lip6.fr> <1477769829-22230-9-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1477769829-22230-9-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall , Benjamin Herrenschmidt Cc: kernel-janitors@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Julia Lawall writes: > diff --git a/arch/powerpc/kernel/iommu.c b/arch/powerpc/kernel/iommu.c > index 5f202a5..32f18b5 100644 > --- a/arch/powerpc/kernel/iommu.c > +++ b/arch/powerpc/kernel/iommu.c > @@ -127,8 +127,7 @@ static ssize_t fail_iommu_store(struct device *dev, > return count; > } > > -static DEVICE_ATTR(fail_iommu, S_IRUGO|S_IWUSR, fail_iommu_show, > - fail_iommu_store); > +static DEVICE_ATTR_RW(fail_iommu); Acked-by: Michael Ellerman (powerpc) cheers