* [PATCH] Input: mt6779-keypad - fix signedness bug in probe
@ 2022-03-14 14:00 Dan Carpenter
2022-03-14 14:37 ` Mattijs Korpershoek
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-03-14 14:00 UTC (permalink / raw)
To: Dmitry Torokhov, fengping.yu
Cc: Matthias Brugger, Mattijs Korpershoek, Marco Felsch,
Andy Shevchenko, linux-input, linux-mediatek, kernel-janitors
The "irq" variable needs to be signed for the error handling to work.
Fixes: f28af984e771 ("Input: mt6779-keypad - add MediaTek keypad driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/input/keyboard/mt6779-keypad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/mt6779-keypad.c b/drivers/input/keyboard/mt6779-keypad.c
index 5ff23250ed37..abd7e346203d 100644
--- a/drivers/input/keyboard/mt6779-keypad.c
+++ b/drivers/input/keyboard/mt6779-keypad.c
@@ -91,10 +91,10 @@ static void mt6779_keypad_clk_disable(void *data)
static int mt6779_keypad_pdrv_probe(struct platform_device *pdev)
{
struct mt6779_keypad *keypad;
- unsigned int irq;
u32 debounce;
bool wakeup;
int error;
+ int irq;
keypad = devm_kzalloc(&pdev->dev, sizeof(*keypad), GFP_KERNEL);
if (!keypad)
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Input: mt6779-keypad - fix signedness bug in probe
2022-03-14 14:00 [PATCH] Input: mt6779-keypad - fix signedness bug in probe Dan Carpenter
@ 2022-03-14 14:37 ` Mattijs Korpershoek
0 siblings, 0 replies; 2+ messages in thread
From: Mattijs Korpershoek @ 2022-03-14 14:37 UTC (permalink / raw)
To: Dan Carpenter, Dmitry Torokhov, fengping.yu
Cc: Matthias Brugger, Marco Felsch, Andy Shevchenko, linux-input,
linux-mediatek, kernel-janitors
Hi Dan,
On lun., mars 14, 2022 at 17:00, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The "irq" variable needs to be signed for the error handling to work.
>
> Fixes: f28af984e771 ("Input: mt6779-keypad - add MediaTek keypad driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thank you for the patch.
This was already reported and fixed at [1]
[1] https://lore.kernel.org/linux-input/20220308025054.2077162-1-lv.ruyi@zte.com.cn/
> ---
> drivers/input/keyboard/mt6779-keypad.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/mt6779-keypad.c b/drivers/input/keyboard/mt6779-keypad.c
> index 5ff23250ed37..abd7e346203d 100644
> --- a/drivers/input/keyboard/mt6779-keypad.c
> +++ b/drivers/input/keyboard/mt6779-keypad.c
> @@ -91,10 +91,10 @@ static void mt6779_keypad_clk_disable(void *data)
> static int mt6779_keypad_pdrv_probe(struct platform_device *pdev)
> {
> struct mt6779_keypad *keypad;
> - unsigned int irq;
> u32 debounce;
> bool wakeup;
> int error;
> + int irq;
>
> keypad = devm_kzalloc(&pdev->dev, sizeof(*keypad), GFP_KERNEL);
> if (!keypad)
> --
> 2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-14 14:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-14 14:00 [PATCH] Input: mt6779-keypad - fix signedness bug in probe Dan Carpenter
2022-03-14 14:37 ` Mattijs Korpershoek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).