From: Kalle Valo <kvalo@codeaurora.org>
To: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Amitkumar Karwar <amit.karwar@redpinesignals.com>,
Prameela Rani Garnepudi <prameela.j04cs@gmail.com>,
Karun Eagalapati <karun256@gmail.com>,
Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] rsi: remove unecessary PTR_ALIGN()s
Date: Fri, 06 Apr 2018 09:01:40 +0000 [thread overview]
Message-ID: <87woxkd7yj.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <5AC7338C.3000307@broadcom.com> (Arend van Spriel's message of "Fri, 6 Apr 2018 10:45:00 +0200")
Arend van Spriel <arend.vanspriel@broadcom.com> writes:
> On 4/6/2018 10:37 AM, Dan Carpenter wrote:
>> The issue here is that we allocate "data" and then set
>> "data = PTR_ALIGN(data, 8);" and then we free the aligned pointer
>> instead of the original pointer.
>>
>> kmalloc() pointers are already ARCH_SLAB_MINALIGN aligned which is 8 or
>> more on everything except certain Xtensa variants. We decided that if
>> the Xtensa people ever notice a bug here then we'll tell them the bug is
>> on their side. ;)
>
> I am not sure if it was decided to be a xtensa bug, but just to ignore
> the issue until it would arise.
IIRC on other architectures the allocation is already aligned properly
so there shouldn't be any functional changes with this patch, expect on
xtensa of course.
> Anyway, not sure if the last sentence is useful in the commit message.
IMHO it is useful as it gives a summary of our discussion, just with a
humorous tone :)
--
Kalle Valo
next prev parent reply other threads:[~2018-04-06 9:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 11:23 [PATCH] rsi: Free the unaligned pointer Dan Carpenter
2018-04-05 11:30 ` Johannes Berg
2018-04-05 11:39 ` Dan Carpenter
2018-04-05 11:41 ` Dan Carpenter
2018-04-05 11:46 ` Johannes Berg
2018-04-05 12:23 ` Kalle Valo
2018-04-06 8:37 ` [PATCH v2] rsi: remove unecessary PTR_ALIGN()s Dan Carpenter
2018-04-06 8:45 ` Arend van Spriel
2018-04-06 9:01 ` Kalle Valo [this message]
2018-04-24 17:24 ` [v2] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87woxkd7yj.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=amit.karwar@redpinesignals.com \
--cc=arend.vanspriel@broadcom.com \
--cc=dan.carpenter@oracle.com \
--cc=karun256@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=prameela.j04cs@gmail.com \
--cc=siva.rebbagondla@redpinesignals.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox