* Re: [PATCH -next] gpio: pxa: remove set but not used variable 'gpio_offset'
@ 2018-08-01 19:48 Robert Jarzmik
2018-08-02 21:33 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Robert Jarzmik @ 2018-08-01 19:48 UTC (permalink / raw)
To: kernel-janitors
Wei Yongjun <weiyongjun1@huawei.com> writes:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpio/gpio-pxa.c: In function ‘pxa_gpio_probe’:
> drivers/gpio/gpio-pxa.c:629:35: warning:
> variable ‘gpio_offset’ set but not used [-Wunused-but-set-variable]
There are weird characters here : ‘ and ’
> int irq0 = 0, irq1 = 0, irq_mux, gpio_offset = 0;
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Once that is fixed,
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] gpio: pxa: remove set but not used variable 'gpio_offset'
2018-08-01 19:48 [PATCH -next] gpio: pxa: remove set but not used variable 'gpio_offset' Robert Jarzmik
@ 2018-08-02 21:33 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2018-08-02 21:33 UTC (permalink / raw)
To: kernel-janitors
On Wed, Aug 1, 2018 at 3:33 AM Wei Yongjun <weiyongjun1@huawei.com> wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpio/gpio-pxa.c: In function ‘pxa_gpio_probe’:
> drivers/gpio/gpio-pxa.c:629:35: warning:
> variable ‘gpio_offset’ set but not used [-Wunused-but-set-variable]
> int irq0 = 0, irq1 = 0, irq_mux, gpio_offset = 0;
> ^
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Fixed up the funny characters and applied with Robert's ACK!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-02 21:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-01 19:48 [PATCH -next] gpio: pxa: remove set but not used variable 'gpio_offset' Robert Jarzmik
2018-08-02 21:33 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox