From: Jani Nikula <jani.nikula@linux.intel.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: Joe Perches <joe@perches.com>,
Julia Lawall <julia.lawall@lip6.fr>,
Al Viro <viro@ZenIV.linux.org.uk>,
Ilya Dryomov <idryomov@gmail.com>,
Andy Whitcroft <apw@canonical.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
Ceph Development <ceph-devel@vger.kernel.org>,
Alex Elder <elder@kernel.org>, Sage Weil <sage@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-doc@vger.kernel.org
Subject: Re: "CodingStyle: Clarify and complete chapter 7" in docs-next
Date: Thu, 22 Sep 2016 13:06:00 +0000 [thread overview]
Message-ID: <87zin0nkxz.fsf@intel.com> (raw)
In-Reply-To: <20160922144648.10efc7ac@endymion>
On Thu, 22 Sep 2016, Jean Delvare <jdelvare@suse.de> wrote:
> Hi Jani,
>
> On Thu, 22 Sep 2016 13:43:42 +0300, Jani Nikula wrote:
>>
>> You could make checkpatch have different defaults for patches and files,
>> to encourage better style in new code, but to discourage finding
>> problems in existing code.
>
> Fixing old code isn't wrong per se. It's good actually. But only if
> done the right way by the right person. I don't think it makes any
> sense to use this task as an introduction to kernel development for
> newcomers. It doesn't teach them anything about the kernel, really.
Mostly agreed, though I'd go as far as saying certain classes of
(checkpatch) issues aren't worth fixing, at all, by anyone, except
perhaps while changing the code anyway for some other purpose.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
prev parent reply other threads:[~2016-09-22 13:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 11:53 "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adjust Ilya Dryomov
2016-09-20 0:11 ` "CodingStyle: Clarify and complete chapter 7" in docs-next (was Re: [PATCH 03/47] block-rbd: Adj Al Viro
2016-09-20 2:46 ` Joe Perches
2016-09-20 5:53 ` Julia Lawall
2016-09-20 6:32 ` Joe Perches
2016-09-20 6:46 ` Julia Lawall
2016-09-22 9:24 ` "CodingStyle: Clarify and complete chapter 7" in docs-next Jean Delvare
2016-09-22 10:42 ` Joe Perches
2016-09-22 11:57 ` Jean Delvare
2016-09-22 13:11 ` Al Viro
2016-09-22 14:58 ` Jean Delvare
2016-09-22 15:05 ` Julia Lawall
2016-09-22 17:50 ` Joe Perches
2016-09-22 17:49 ` Joe Perches
2016-09-22 19:47 ` Jean Delvare
2016-09-22 10:43 ` Jani Nikula
2016-09-22 12:46 ` Jean Delvare
2016-09-22 13:06 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zin0nkxz.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=ceph-devel@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=elder@kernel.org \
--cc=idryomov@gmail.com \
--cc=jdelvare@suse.de \
--cc=joe@perches.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox