From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Thu, 06 Apr 2017 20:33:00 +0000 Subject: Re: IB/qib: Adjust two size determinations in qib_init_pportdata() Message-Id: <8991d27a-0b8d-70f5-81d2-c830c3dd6f78@users.sourceforge.net> List-Id: References: <20170405143242.GB5006@yuval-lap> <523b0864-e655-ed1f-8fe5-5995e0b0bde1@users.sourceforge.net> <20170405151525.GA5519@yuval-lap> <20170406194823.GA28301@yuval-lap> In-Reply-To: <20170406194823.GA28301@yuval-lap> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yuval Shaia Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Doug Ledford , Hal Rosenstock , Mike Marciniszyn , Sean Hefty , LKML , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> How do you think about to take another look at remaining update candidates >> at other source code places for this Linux module? > > You mean the other patches in this patch-set? Partly, yes. - Do you care for adjustments around numbered jump labels (and suggestions from the script "checkpatch.pl") for example? Will it be more important to check return values from all calls of a function like "kmalloc" in related source files? Regards, Markus