From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Date: Mon, 23 Aug 2010 11:36:43 +0000 Subject: Re: [patch] i915: return -EFAULT if copy_to_user fails Message-Id: <89k83a$9d5e6n@azsmga001.ch.intel.com> List-Id: References: <20100623170217.GA15424@bicker> In-Reply-To: <20100623170217.GA15424@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , David Airlie Cc: Daniel Vetter , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Dave Airlie On Wed, 23 Jun 2010 19:03:01 +0200, Dan Carpenter wrote: > copy_to_user() returns the number of bytes remaining to be copied and > I'm pretty sure we want to return a negative error code here. > > Signed-off-by: Dan Carpenter Reviewed-by: Chris Wilson -- Chris Wilson, Intel Open Source Technology Centre