From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Wolfram Sang <wsa@the-dreams.de>,
Haiyang Zhang <haiyangz@microsoft.com>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
devel@linuxdriverproject.org
Subject: Re: vmbus: Delete an error message for a failed memory allocation in vmbus_device_create()
Date: Fri, 12 May 2017 07:32:39 +0000 [thread overview]
Message-ID: <8d38547f-a086-438a-5b2a-4d11929530ec@users.sourceforge.net> (raw)
In-Reply-To: <20170512070909.xxa62d2cde3qoj4f@mwanda>
>> Just because an automated tool says that this needs to change does not
>> mean it has to.
>
> Checkpatch.pl is correct here. This message is useless. It's during
> init so it's unlikely to fail ever. In current kernels small kmallocs
> are quaranteed to succeed so it can't actually fail currently. The
> stack trace is more useful than this message because it tells you a lot
> about what memory is free and the whole call tree.
>
> The error message is dead useless code.
Would you like to clarify corresponding software evolution any more?
Is there a need for better documentation of the involved programming interfaces?
> This patch is not going to be merged because Markus doesn't listen to
> feedback and he's blocked but otherwise it's an OK patch.
Does this information contain a contradiction?
Will patches be picked up also from contributors who got a special
development reputation anyhow?
Regards,
Markus
next prev parent reply other threads:[~2017-05-12 7:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 16:14 [PATCH 0/4] VMBus: Adjustments for some function implementations SF Markus Elfring
2017-05-11 16:15 ` [PATCH 1/4] vmbus: Improve a size determination in vmbus_device_create() SF Markus Elfring
2017-05-11 16:30 ` Stephen Hemminger
2017-05-11 17:47 ` Greg KH
2017-05-11 16:17 ` [PATCH 2/4] vmbus: Delete an error message for a failed memory allocation " SF Markus Elfring
2017-05-11 16:30 ` [PATCH 2/4] vmbus: Delete an error message for a failed memory allocation in vmbus_device_create Stephen Hemminger
2017-05-11 16:36 ` vmbus: Delete an error message for a failed memory allocation in vmbus_device_create() SF Markus Elfring
2017-05-11 16:42 ` Stephen Hemminger
2017-05-12 7:09 ` [PATCH 2/4] vmbus: Delete an error message for a failed memory allocation in vmbus_device_create Dan Carpenter
2017-05-12 7:32 ` SF Markus Elfring [this message]
2017-05-12 7:52 ` vmbus: Delete an error message for a failed memory allocation in vmbus_device_create() Joe Perches
2017-05-12 8:23 ` Clarification for general change acceptance SF Markus Elfring
2017-05-12 8:37 ` Julia Lawall
2017-05-12 8:45 ` SF Markus Elfring
2017-05-11 16:18 ` [PATCH 3/4] vmbus: Fix a typo in a comment line SF Markus Elfring
2017-05-11 16:33 ` Stephen Hemminger
2017-05-11 16:19 ` [PATCH 4/4] vmbus: Adjust five checks for null pointers SF Markus Elfring
2017-05-11 16:34 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d38547f-a086-438a-5b2a-4d11929530ec@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox