From: Markus Elfring <Markus.Elfring@web.de>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>,
netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
Bharat Bhushan <bbhushan2@marvell.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Geethasowjanya Akula <gakula@marvell.com>,
Hariprasad Kelam <hkelam@marvell.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
Sunil Goutham <sgoutham@marvell.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Dan Carpenter <error27@gmail.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH net v2 1/2] octeontx2-pf: fix netdev memory leak in rvu_rep_create()
Date: Wed, 18 Dec 2024 18:38:25 +0100 [thread overview]
Message-ID: <8d54b21b-7ca9-4126-ba13-bbd333d6ba0c@web.de> (raw)
In-Reply-To: <20241217052326.1086191-1-harshit.m.mogalapalli@oracle.com>
> When rvu_rep_devlink_port_register() fails, free_netdev(ndev) for this
> incomplete iteration before going to "exit:" label.
…
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
> @@ -680,8 +680,10 @@ int rvu_rep_create(struct otx2_nic *priv, struct netlink_ext_ack *extack)
> ndev->features |= ndev->hw_features;
> eth_hw_addr_random(ndev);
> err = rvu_rep_devlink_port_register(rep);
> - if (err)
> + if (err) {
> + free_netdev(ndev);
> goto exit;
> + }
>
> SET_NETDEV_DEVLINK_PORT(ndev, &rep->dl_port);
…
I suggest to add another jump target instead so that a bit of exception handling
can be better reused at the end of this function implementation.
Regards,
Markus
next prev parent reply other threads:[~2024-12-18 17:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 5:23 [PATCH net v2 1/2] octeontx2-pf: fix netdev memory leak in rvu_rep_create() Harshit Mogalapalli
2024-12-17 5:23 ` [PATCH net v2 2/2] octeontx2-pf: fix error handling of devlink port " Harshit Mogalapalli
2024-12-18 6:04 ` [EXTERNAL] " Geethasowjanya Akula
2024-12-18 6:03 ` [EXTERNAL] [PATCH net v2 1/2] octeontx2-pf: fix netdev memory leak " Geethasowjanya Akula
2024-12-18 17:38 ` Markus Elfring [this message]
2024-12-18 17:51 ` Dan Carpenter
2024-12-19 3:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d54b21b-7ca9-4126-ba13-bbd333d6ba0c@web.de \
--to=markus.elfring@web.de \
--cc=andrew+netdev@lunn.ch \
--cc=bbhushan2@marvell.com \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=error27@gmail.com \
--cc=gakula@marvell.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=hkelam@marvell.com \
--cc=horms@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox