From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rajkumar Manoharan Date: Wed, 13 May 2020 21:22:58 +0000 Subject: Re: [PATCH] ath11k: Fix some resource leaks in error path in 'ath11k_thermal_register()' Message-Id: <8ee716c797a547165132c179c1909404@codeaurora.org> List-Id: References: <20200513201454.258111-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20200513201454.258111-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christophe JAILLET Cc: kernel-janitors@vger.kernel.org, pradeepc@codeaurora.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath11k@lists.infradead.org, linux-wireless-owner@vger.kernel.org, davem@davemloft.net, kvalo@codeaurora.org On 2020-05-13 13:14, Christophe JAILLET wrote: > If 'thermal_cooling_device_register()' fails, we must undo what has > been > allocated so far. So we must go to 'err_thermal_destroy' instead of > returning directly > > In case of error in 'ath11k_thermal_register()', the previous > 'thermal_cooling_device_register()' call must also be undone. Move the > 'ar->thermal.cdev = cdev' a few lines above in order for this to be > done > in 'ath11k_thermal_unregister()' which is called in the error handling > path. > > Fixes: 2a63bbca06b2 ("ath11k: add thermal cooling device support") > Signed-off-by: Christophe JAILLET > --- > I'm not 100% confident with this patch. > > - When calling 'ath11k_thermal_unregister()', we try to release some > resources that have not been allocated yet. I don't know if it can be > an > issue or not. > - I think that we should propagate the error code, instead of forcing > -EINVAL. > Good catch. -Rajkumar