From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,PDS_BAD_THREAD_QP_64,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B26C6C433E0 for ; Tue, 9 Mar 2021 16:58:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8BCBD6522A for ; Tue, 9 Mar 2021 16:58:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229799AbhCIQ6W (ORCPT ); Tue, 9 Mar 2021 11:58:22 -0500 Received: from mx01-muc.bfs.de ([193.174.230.67]:51932 "EHLO mx01-muc.bfs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230504AbhCIQ6B (ORCPT ); Tue, 9 Mar 2021 11:58:01 -0500 Received: from SRVEX01-SZ.bfs.intern (exchange-sz.bfs.de [10.129.90.31]) by mx01-muc.bfs.de (Postfix) with ESMTPS id F37F1203A7; Tue, 9 Mar 2021 17:57:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bfs.de; s=dkim201901; t=1615309080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h+ADzz2PycqRDNDzhaK4am45/205Sa55O9WLjE4qfmg=; b=F68hKU06BJHN+y2ktMTlItFlL2+T71UpTKGMr9UacVLdiWwp48e17hbUVlKOgAwqIC3DpW Z+8ovBBpxlT7fHTLaZNXmgQ8pnDbKzNXTmpLXY0VpF2XOgIm/WUjypq07XnSq1OaxGQ2V2 /KwzW9iHlchk4kWupVxqQG1je1vv7vEgDq8AiYiGS+KGxMto1m/LUj5A3T2Zc0TrF5LAla mmV738cCEhLhgnEnlxn8cKk0y2W5nN2y7wdTXop2B3OFkiidS7sC/OpcUU4tmCYF158M8y 6ekl/txebMK3fzcLZBZpWCe7wBKMlOLM6Lkk/RoAo7ZYi0X45mU8PEQtu0yB8g== Received: from SRVEX01-SZ.bfs.intern (10.129.90.31) by SRVEX01-SZ.bfs.intern (10.129.90.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2176.2; Tue, 9 Mar 2021 17:57:59 +0100 Received: from SRVEX01-SZ.bfs.intern ([fe80::7d2d:f9cb:2761:d24a]) by SRVEX01-SZ.bfs.intern ([fe80::7d2d:f9cb:2761:d24a%13]) with mapi id 15.01.2176.009; Tue, 9 Mar 2021 17:57:59 +0100 From: Walter Harms To: Greg Kroah-Hartman , Dan Carpenter CC: Rob Springer , "devel@driverdev.osuosl.org" , "kernel-janitors@vger.kernel.org" , John Joseph , "Simon Que" , Richard Yeh , Todd Poynor Subject: AW: [PATCH] staging: gasket: Fix sizeof() in gasket_handle_ioctl() Thread-Topic: [PATCH] staging: gasket: Fix sizeof() in gasket_handle_ioctl() Thread-Index: AQHW8NHDjHLYhGhXpkyIIUiTZnjQVqp73VeAgABGW/A= Date: Tue, 9 Mar 2021 16:57:59 +0000 Message-ID: <8fda6445b7944426a45a944b777c52fe@bfs.de> References: , In-Reply-To: Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.137.16.39] x-tm-as-product-ver: SMEX-14.0.0.3080-8.6.1012-26020.000 x-tm-as-result: No-10--5.167600-5.000000 x-tmase-matchedrid: vSacEmmxy1cI9V8p1Mx66RvgzEPRJaDEKQNhMboqZloTiSW9r3PknDmy vi/pk1f1Xrb4QOzuDtdLrEBPgdA+3JW93I1R56ceGuJkjglgeN8BDya2JbH/+lSXiT718GEQ1t2 9KLWKRj6byHEAgTCz2tzQyfWsxJJtPg9yfk4YC0bobINHZkH5xgsE9gx+4jJue5Q84fGfhIaHxT OO6g/RXs9X4Dcy3usP7i7ibx9W3/mIxltsBoyvHqiUivh0j2PvSWg+u4ir2NOok1v2BTdbi+xi+ /EGZYtTdZ7fu9NDAa5M5aeo/ogZvU6QGdtaTwWBfJy8LojR0khUIaneDj+GO1IGXWOWGJcxJY8L 9eqtVP4fKptxQz8aGHEfMpvQYpcibTSwI/A2DvB08zy97KsgJtDZ1FFTJUymg8vHe9ji82KgYvM 2hSr9WhXL6mT9IaQBPZdZhZKItfKPaFHMfVTC4IMbH85DUZXyXU/IDt4T4+H6C0ePs7A07b4iOw QQ4jNiCXP6o8jmVGf9TaKQPBlYpuFY2VZFv67TGGEMK3KhUcs= x-tm-as-user-approved-sender: No x-tm-as-user-blocked-sender: No x-tmase-result: 10--5.167600-5.000000 x-tmase-version: SMEX-14.0.0.3080-8.6.1012-26020.000 x-tm-snts-smtp: 747D4B5F53BB096DB7D52720A9BF59CB7C1D7393A296FE2AA9F8704875D9EAFD2000:9 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Authentication-Results: mx01-muc.bfs.de; none X-Spamd-Result: default: False [-15.00 / 7.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[bfs.de:s=dkim201901]; RCPT_COUNT_SEVEN(0.00)[9]; WHITELIST_LOCAL_IP(-15.00)[10.129.90.31]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; BAYES_HAM(-0.00)[32.48%] Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org why not mark it as "Deprecated" and remove it with the next version ? Maybe= soneone will wakeup ? re, wh ________________________________________ Von: Greg Kroah-Hartman Gesendet: Dienstag, 9. M=E4rz 2021 14:26:55 An: Dan Carpenter Cc: Rob Springer; devel@driverdev.osuosl.org; kernel-janitors@vger.kernel.o= rg; John Joseph; Simon Que; Richard Yeh; Todd Poynor Betreff: Re: [PATCH] staging: gasket: Fix sizeof() in gasket_handle_ioctl() On Fri, Jan 22, 2021 at 06:01:13PM +0300, Dan Carpenter wrote: > The "gasket_dev->num_page_tables" variable is an int but this is copying > sizeof(u64). On 32 bit systems this would end up disclosing a kernel > pointer to user space, but on 64 bit it copies zeroes from a struct > hole. > > Fixes: 9a69f5087ccc ("drivers/staging: Gasket driver framework + Apex dri= ver") > Signed-off-by: Dan Carpenter > --- > This is an API change. Please review this carefully! Another potential > fix would be to make ->num_page_tables a long instead of an int. > > drivers/staging/gasket/gasket_ioctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks like this driver is dead, with no response from anyone from Google. Should I just delete it? The goal of using normal apis and getting this out of staging seems to have totally died, so it shouldn't even still be living in the kernel tree. Even if having it here actually finds security issues that the authors missed like this :( So, any objection to me deleting it? thanks, greg k-h