From: Kishon Vijay Abraham I <kishon@ti.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Andreas Fenkart <afenkart@gmail.com>
Cc: Sekhar Nori <nsekhar@ti.com>, Ravikumar Kattekola <rk@ti.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Tony Lindgren <tony@atomide.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mmc: host: omap_hsmmc: checking for NULL instead of IS_ERR()
Date: Mon, 10 Apr 2017 14:17:00 +0000 [thread overview]
Message-ID: <93202f3b-e3c7-1593-3395-db4123cf6329@ti.com> (raw)
In-Reply-To: <20170410135417.GD1918@mwanda>
On Monday 10 April 2017 07:24 PM, Dan Carpenter wrote:
> devm_pinctrl_get() returns error pointers, it never returns NULL.
>
> Fixes: 455e5cd6f736 ("mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
FWIW:
Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com>
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index bf64cf23aa59..8c39dccacf39 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -1761,8 +1761,8 @@ static int omap_hsmmc_configure_wake_irq(struct omap_hsmmc_host *host)
> */
> if (host->pdata->controller_flags & OMAP_HSMMC_SWAKEUP_MISSING) {
> struct pinctrl *p = devm_pinctrl_get(host->dev);
> - if (!p) {
> - ret = -ENODEV;
> + if (IS_ERR(p)) {
> + ret = PTR_ERR(p);
> goto err_free_irq;
> }
> if (IS_ERR(pinctrl_lookup_state(p, PINCTRL_STATE_DEFAULT))) {
>
next prev parent reply other threads:[~2017-04-10 14:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 13:54 [PATCH] mmc: host: omap_hsmmc: checking for NULL instead of IS_ERR() Dan Carpenter
2017-04-10 14:17 ` Kishon Vijay Abraham I [this message]
2017-04-12 14:11 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93202f3b-e3c7-1593-3395-db4123cf6329@ti.com \
--to=kishon@ti.com \
--cc=afenkart@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=hkallweit1@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=rk@ti.com \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox