From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Thu, 09 Nov 2017 13:22:18 +0000 Subject: Re: bq2415x_charger: Use common error handling code in bq2415x_timer_work() Message-Id: <935e992c-e5ee-841b-c42a-4a7bf891d984@users.sourceforge.net> List-Id: References: <48b34d35-8c41-d25b-0cb7-6257b37c5a44@users.sourceforge.net> <20171109120842.GA28552@atrey.karlin.mff.cuni.cz> <20171109131433.x7xuh4bqvqm72wb5@pali> In-Reply-To: <20171109131433.x7xuh4bqvqm72wb5@pali> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , linux-pm@vger.kernel.org Cc: Pavel Machek , Sebastian Reichel , LKML , kernel-janitors@vger.kernel.org >> Which information (or wording) would you find more appropriate >> at these places? > > Hi! Basically dropping your patch and instead of the "Unknown error" > return to user reason why BQ2415X_BOOST_MODE_STATUS or > BQ2415X_FAULT_STATUS commands failed. Or at least instead of the > "Unknown error" write "Unknown error during BQ2415X_FAULT_STATUS". Can the error description become better? Regards, Markus