From: SF Markus Elfring <elfring@users.sourceforge.net>
To: cluster-devel@redhat.com,
Christine Caulfield <ccaulfie@redhat.com>,
David Teigland <teigland@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 04/10] dlm: Use kcalloc() in dlm_scan_waiters()
Date: Sat, 06 May 2017 08:40:19 +0000 [thread overview]
Message-ID: <9b591257-7dd1-97ca-b12d-55c963e0c528@users.sourceforge.net> (raw)
In-Reply-To: <4bd895d7-9448-928d-1e4c-42326ce20607@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 6 May 2017 08:38:49 +0200
A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kcalloc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
fs/dlm/lock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 6df332296c66..fd6fe55bedae 100644
--- a/fs/dlm/lock.c
+++ b/fs/dlm/lock.c
@@ -1426,7 +1426,7 @@ void dlm_scan_waiters(struct dlm_ls *ls)
if (!num_nodes) {
num_nodes = ls->ls_num_nodes;
- warned = kzalloc(num_nodes * sizeof(int), GFP_KERNEL);
+ warned = kcalloc(num_nodes, sizeof(int), GFP_KERNEL);
}
if (!warned)
continue;
--
2.12.2
next prev parent reply other threads:[~2017-05-06 8:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-06 8:34 [PATCH 00/10] fs-DLM: Fine-tuning for several function implementations SF Markus Elfring
2017-05-06 8:36 ` [PATCH 01/10] dlm: Replace six seq_puts() calls by seq_putc() SF Markus Elfring
2017-05-06 8:38 ` [PATCH 02/10] dlm: Add spaces for better code readability SF Markus Elfring
2017-05-06 8:39 ` [PATCH 03/10] dlm: Improve a size determination in table_seq_start() SF Markus Elfring
2017-05-06 8:40 ` SF Markus Elfring [this message]
2017-05-06 8:41 ` [PATCH 05/10] dlm: Improve a size determination in dlm_recover_waiters_pre() SF Markus Elfring
2017-05-06 8:43 ` [PATCH 06/10] dlm: Delete an error message for a failed memory allocation in dlm_recover_waiters_pre SF Markus Elfring
2017-05-06 8:44 ` [PATCH 07/10] dlm: Use kmalloc_array() in make_member_array() SF Markus Elfring
2017-05-06 8:45 ` [PATCH 08/10] dlm: Use kcalloc() in two functions SF Markus Elfring
2017-05-06 8:47 ` [PATCH 09/10] dlm: Improve a size determination " SF Markus Elfring
2017-05-06 8:48 ` [PATCH 10/10] dlm: Delete an unnecessary variable initialisation in dlm_ls_start() SF Markus Elfring
2017-05-08 20:08 ` [Cluster-devel] [PATCH 00/10] fs-DLM: Fine-tuning for several function implementations Bob Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b591257-7dd1-97ca-b12d-55c963e0c528@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=ccaulfie@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox