From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Prabhakar Lad <prabhakar.csengg@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 1/3] [media] DaVinci-VPBE-Display: Delete an error message for a failed memory allocation in
Date: Fri, 08 Sep 2017 12:31:05 +0000 [thread overview]
Message-ID: <9be97d7f-57bc-1c7e-fd86-187a38e0f994@users.sourceforge.net> (raw)
In-Reply-To: <e980c48c-9525-4942-a58e-20af8a96e531@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 7 Sep 2017 22:37:16 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/media/platform/davinci/vpbe_display.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/davinci/vpbe_display.c b/drivers/media/platform/davinci/vpbe_display.c
index 13d027031ff0..5b6fc550736b 100644
--- a/drivers/media/platform/davinci/vpbe_display.c
+++ b/drivers/media/platform/davinci/vpbe_display.c
@@ -1313,7 +1313,6 @@ static int init_vpbe_layer(int i, struct vpbe_display *disp_dev,
- if (!disp_dev->dev[i]) {
- printk(KERN_ERR "ran out of memory\n");
+ if (!disp_dev->dev[i])
return -ENOMEM;
- }
+
spin_lock_init(&disp_dev->dev[i]->irqlock);
mutex_init(&disp_dev->dev[i]->opslock);
--
2.14.1
next prev parent reply other threads:[~2017-09-08 12:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 12:29 [PATCH 0/3] [media] DaVinci-VPBE-Display: Adjustments for some function implementations SF Markus Elfring
2017-09-08 12:31 ` SF Markus Elfring [this message]
2017-09-11 13:20 ` [PATCH 1/3] [media] DaVinci-VPBE-Display: Delete an error message for a failed memory allocation Lad, Prabhakar
2017-09-08 12:32 ` [PATCH 2/3] [media] DaVinci-VPBE-Display: Improve a size determination in two functions SF Markus Elfring
2017-09-11 13:23 ` Lad, Prabhakar
2017-09-08 12:33 ` [PATCH 3/3] [media] DaVinci-VPBE-Display: Adjust 12 checks for null pointers SF Markus Elfring
2017-09-11 13:26 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9be97d7f-57bc-1c7e-fd86-187a38e0f994@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=prabhakar.csengg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox