From: Alexandra Winter <wintera@linux.ibm.com>
To: Dan Carpenter <dan.carpenter@linaro.org>,
Julian Ruess <julianr@linux.ibm.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] dibs: Check correct variable in dibs_init()
Date: Wed, 24 Sep 2025 18:49:53 +0200 [thread overview]
Message-ID: <9d48c84b-c686-4d79-9b56-ede551ad62fc@linux.ibm.com> (raw)
In-Reply-To: <aNP-XcrjSUjZAu4a@stanley.mountain>
On 24.09.25 16:21, Dan Carpenter wrote:
> There is a typo in this code. It should check "dibs_class" instead of
> "&dibs_class". Remove the &.
>
> Fixes: 804737349813 ("dibs: Create class dibs")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/dibs/dibs_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dibs/dibs_main.c b/drivers/dibs/dibs_main.c
> index 5425238d5a42..0374f8350ff7 100644
> --- a/drivers/dibs/dibs_main.c
> +++ b/drivers/dibs/dibs_main.c
> @@ -258,8 +258,8 @@ static int __init dibs_init(void)
> max_client = 0;
>
> dibs_class = class_create("dibs");
> - if (IS_ERR(&dibs_class))
> - return PTR_ERR(&dibs_class);
> + if (IS_ERR(dibs_class))
> + return PTR_ERR(dibs_class);
>
> rc = dibs_loopback_init();
> if (rc)
oops, this has been wrong since the first RFC in february.
Great catch, thank you Dan.
Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
next prev parent reply other threads:[~2025-09-24 16:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 14:21 [PATCH net-next] dibs: Check correct variable in dibs_init() Dan Carpenter
2025-09-24 16:49 ` Alexandra Winter [this message]
2025-09-26 22:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d48c84b-c686-4d79-9b56-ede551ad62fc@linux.ibm.com \
--to=wintera@linux.ibm.com \
--cc=dan.carpenter@linaro.org \
--cc=julianr@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox