From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Darren Hart <dvhart@infradead.org>,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Andy Shevchenko <andy@infradead.org>,
Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: platform/x86/thinkpad_acpi: Adjustments for four function implementations
Date: Wed, 03 Jan 2018 08:41:04 +0000 [thread overview]
Message-ID: <9ea2c1c7-a07d-19c3-a2dc-0c69352d9558@users.sourceforge.net> (raw)
In-Reply-To: <20180103001034.GC24794@fury>
> I understand it can be frustrating to encounter different policies
> across kernel maintainers.
The change acceptance is varying for special transformation patterns.
> You'll even run in to this with maintainers of the same subsystem
> from time to time.
Interesting, isn't it?
> I'm supportive of cleaning up old code in general,
Nice.
> and we routinely apply such patches as these developed with cocci.
Good to know …
> 1. This is init code )so any space savings is short lived)
Would you dare to achieve another small improvement there?
> So it isn't that we place a low value on coding style guidelines,
> but rather we place higher value on not perturbing code
I can follow this view in principle.
> we can't fully test without a demonstrable functional reasons to do so.
How do you think about to get a bit nicer run time characteristics?
Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-01-03 8:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 21:26 [PATCH 0/2] platform/x86/thinkpad_acpi: Adjustments for four function implementations SF Markus Elfring
2017-12-18 21:28 ` [PATCH 1/2] platform/x86/thinkpad_acpi: Delete an error message for a failed memory allocation in th SF Markus Elfring
2017-12-18 21:30 ` [PATCH 2/2] platform/x86/thinkpad_acpi: Improve a size determination in tpacpi_new_rfkill() SF Markus Elfring
2017-12-19 14:37 ` [PATCH 0/2] platform/x86/thinkpad_acpi: Adjustments for four function implementations Andy Shevchenko
2017-12-19 16:23 ` SF Markus Elfring
2017-12-19 17:28 ` Andy Shevchenko
2017-12-23 1:40 ` Henrique de Moraes Holschuh
2017-12-23 7:12 ` SF Markus Elfring
2018-01-03 0:10 ` Darren Hart
2018-01-03 0:49 ` Joe Perches
2018-01-03 1:13 ` Darren Hart
2018-01-03 8:41 ` SF Markus Elfring [this message]
2018-01-06 1:26 ` Darren Hart
2018-01-06 8:55 ` SF Markus Elfring
2017-12-23 1:29 ` [PATCH 0/2] " Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ea2c1c7-a07d-19c3-a2dc-0c69352d9558@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox