Re: [HPDD-discuss] [PATCH] staging: lustre: code cleanup - variable declaration spacing

Drokin, Oleg
2015-05-08T01:32:34Z

Hello!

On May 7, 2015, at 8:09 AM, Dan Carpenter wrote:

>>> Clean up spacing in some variable declarations, to be more consistent.
>>>
>>> It's small, but I need to start somewhere. Please let me know if I'm not
>>> adhering to proper procedure for trivial cleanups.
>>
>> It's actually Lustre coding style to align the variable declarations.
>> Is this something that causes checkpatch.pl to complain? If not, I'd
>> prefer not to change all of these declarations, since it causes a lot
>> of code churn for very little benefit.
> In theory it's nice, but in reality aligning variables doesn't work in
> .c files. If you look at the patch, almost every declaration block uses
> higgledy piggledy alignment.

I suspect that that's artefact of the initial code submission where the
mostly spaces used for tabs were converted to tabs in some automated manner,
which combined with typedefs removals (also done in automated manner)
like cfs_spinlock_t to spinlock_t and the like produced the result we can see.

Personally I don't care all that much about local variables alignments in the
functions, but alignment of struct members does help, I feel like, so I have been
trying to fix the alignment there whenever I was touching nearby code.

Bye,
Oleg