From: "Vick, Matthew" <matthew.vick@intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
Alexander Duyck <alexander.h.duyck@intel.com>
Cc: "kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"e1000-devel@lists.sourceforge.net"
<e1000-devel@lists.sourceforge.net>,
"Allan, Bruce W" <bruce.w.allan@intel.com>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
Linux NICS <Linux-nics@isotope.jf.intel.com>,
"Ronciak, John" <john.ronciak@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [patch -mainline] fm10k: drop upper bits of VLAN ID
Date: Fri, 30 Jan 2015 17:05:17 +0000 [thread overview]
Message-ID: <D0F0F914.69184%matthew.vick@intel.com> (raw)
In-Reply-To: <20150130105038.GL6507@mwanda>
On 1/30/15, 2:50 AM, "Dan Carpenter" <dan.carpenter@oracle.com> wrote:
>On Fri, Jan 30, 2015 at 11:41:27AM +0300, Dan Carpenter wrote:
>> Static checkers complain that the shifts in "(vid << 4) >> 4" perfectly
>> cancel each other out and the code is a no-op. "vid" is a u16. The
>> comment says that the intention here is to drop the upper bits so I have
>> added a cast to "u16" to do that.
>>
>> Fixes: 401b5383c6c9 ('fm10k: Add support for configuring PF interface')
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
>Oh... Rasmus Villemoes already fixed this.
>
>regards,
>dan carpenter
Yep, we have a patch coming through Jeff's tree now to resolve the issue
(technically my version of the patch, which doesn't try to mask off the
bits but instead rejects an out-of-bounds VLAN ID). Thanks, Dan!
Cheers,
Matthew
prev parent reply other threads:[~2015-01-30 17:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 8:41 [patch -mainline] fm10k: drop upper bits of VLAN ID Dan Carpenter
2015-01-30 10:50 ` Dan Carpenter
2015-01-30 17:05 ` Vick, Matthew [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0F0F914.69184%matthew.vick@intel.com \
--to=matthew.vick@intel.com \
--cc=Linux-nics@isotope.jf.intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox