* [PATCH] arch/parisc: correct use of SHF_ALLOC
@ 2009-08-04 20:27 Julia Lawall
2009-08-05 14:57 ` Kyle McMartin
2009-09-27 18:21 ` John David Anglin
0 siblings, 2 replies; 4+ messages in thread
From: Julia Lawall @ 2009-08-04 20:27 UTC (permalink / raw)
To: Helge Deller, Kyle McMartin, linux-parisc, linux-kernel,
kernel-janitors
From: Julia Lawall <julia@diku.dk>
SHF_ALLOC is suitable for testing against the sh_flags field, not the
sh_type field.
Signed-off-by: Julia Lawall <julia@diku.dk>
---
arch/parisc/kernel/module.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/parisc/kernel/module.c b/arch/parisc/kernel/module.c
index ef5caf2..c904817 100644
--- a/arch/parisc/kernel/module.c
+++ b/arch/parisc/kernel/module.c
@@ -853,7 +853,7 @@ int module_finalize(const Elf_Ehdr *hdr,
* ourselves */
for (i = 1; i < hdr->e_shnum; i++) {
if(sechdrs[i].sh_type = SHT_SYMTAB
- && (sechdrs[i].sh_type & SHF_ALLOC)) {
+ && (sechdrs[i].sh_flags & SHF_ALLOC)) {
int strindex = sechdrs[i].sh_link;
/* FIXME: AWFUL HACK
* The cast is to drop the const from
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arch/parisc: correct use of SHF_ALLOC
2009-08-04 20:27 [PATCH] arch/parisc: correct use of SHF_ALLOC Julia Lawall
@ 2009-08-05 14:57 ` Kyle McMartin
2009-09-27 18:21 ` John David Anglin
1 sibling, 0 replies; 4+ messages in thread
From: Kyle McMartin @ 2009-08-05 14:57 UTC (permalink / raw)
To: Julia Lawall
Cc: Helge Deller, Kyle McMartin, linux-parisc, linux-kernel,
kernel-janitors
On Tue, Aug 04, 2009 at 10:27:07PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> SHF_ALLOC is suitable for testing against the sh_flags field, not the
> sh_type field.
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
Thanks Julia, applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arch/parisc: correct use of SHF_ALLOC
2009-08-04 20:27 [PATCH] arch/parisc: correct use of SHF_ALLOC Julia Lawall
2009-08-05 14:57 ` Kyle McMartin
@ 2009-09-27 18:21 ` John David Anglin
2009-09-28 3:29 ` Kyle McMartin
1 sibling, 1 reply; 4+ messages in thread
From: John David Anglin @ 2009-09-27 18:21 UTC (permalink / raw)
To: Julia Lawall
Cc: Helge Deller, Kyle McMartin, linux-parisc, linux-kernel,
kernel-janitors
Hi Kyle,
I noticed today that this change is not in 2.6.31.1.
Dave
On Tue, 04 Aug 2009, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> SHF_ALLOC is suitable for testing against the sh_flags field, not the
> sh_type field.
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> arch/parisc/kernel/module.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/parisc/kernel/module.c b/arch/parisc/kernel/module.c
> index ef5caf2..c904817 100644
> --- a/arch/parisc/kernel/module.c
> +++ b/arch/parisc/kernel/module.c
> @@ -853,7 +853,7 @@ int module_finalize(const Elf_Ehdr *hdr,
> * ourselves */
> for (i = 1; i < hdr->e_shnum; i++) {
> if(sechdrs[i].sh_type = SHT_SYMTAB
> - && (sechdrs[i].sh_type & SHF_ALLOC)) {
> + && (sechdrs[i].sh_flags & SHF_ALLOC)) {
> int strindex = sechdrs[i].sh_link;
> /* FIXME: AWFUL HACK
> * The cast is to drop the const from
> --
> To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
J. David Anglin dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6602)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arch/parisc: correct use of SHF_ALLOC
2009-09-27 18:21 ` John David Anglin
@ 2009-09-28 3:29 ` Kyle McMartin
0 siblings, 0 replies; 4+ messages in thread
From: Kyle McMartin @ 2009-09-28 3:29 UTC (permalink / raw)
To: John David Anglin
Cc: Julia Lawall, Helge Deller, Kyle McMartin, linux-parisc,
linux-kernel, kernel-janitors
On Sun, Sep 27, 2009 at 02:21:50PM -0400, John David Anglin wrote:
> Hi Kyle,
>
> I noticed today that this change is not in 2.6.31.1.
>
Dunno what happened... I must have updated patchwork and missed it in a
rebase locally.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-09-28 3:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-04 20:27 [PATCH] arch/parisc: correct use of SHF_ALLOC Julia Lawall
2009-08-05 14:57 ` Kyle McMartin
2009-09-27 18:21 ` John David Anglin
2009-09-28 3:29 ` Kyle McMartin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox