Re: [PATCH 4/10] drivers/net/can/flexcan.c: add missing clk_put

Joe Perches
2011-06-01T17:26:15Z

On Wed, 2011-06-01 at 19:10 +0200, Julia Lawall wrote:
> The failed_get label is used after the call to clk_get has succeeded, so it
> should be moved up above the call to clk_put.
[]
> diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
[]
> @@ -978,8 +978,8 @@ static int __devinit flexcan_probe(struct platform_device *pdev)
> failed_map:
> release_mem_region(mem->start, mem_size);
> failed_req:
> - clk_put(clk);
> failed_get:
> + clk_put(clk);
> failed_clock:
> return err;

If this is correct, it might be better to rename all the
uses of failed_req to failed_get and delete label failed_req.