From: Julia Lawall <julia@diku.dk>
To: Joe Perches <joe@perches.com>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
kernel-janitors@vger.kernel.org, socketcan-core@lists.berlios.de,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/10] drivers/net/can/flexcan.c: add missing clk_put
Date: Wed, 01 Jun 2011 20:08:46 +0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1106012207260.5871@ask.diku.dk> (raw)
In-Reply-To: <1306949175.32125.20.camel@Joe-Laptop>
On Wed, 1 Jun 2011, Joe Perches wrote:
> On Wed, 2011-06-01 at 19:10 +0200, Julia Lawall wrote:
> > The failed_get label is used after the call to clk_get has succeeded, so it
> > should be moved up above the call to clk_put.
> []
> > diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
> []
> > @@ -978,8 +978,8 @@ static int __devinit flexcan_probe(struct platform_device *pdev)
> > failed_map:
> > release_mem_region(mem->start, mem_size);
> > failed_req:
> > - clk_put(clk);
> > failed_get:
> > + clk_put(clk);
> > failed_clock:
> > return err;
>
> If this is correct, it might be better to rename all the
> uses of failed_req to failed_get and delete label failed_req.
As I replied to Walter Harms, I believe it is correct, because I don't see
anything in the called functions that needs to be freed. I can redo the
patch to eliminate the label.
julia
next prev parent reply other threads:[~2011-06-01 20:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 17:10 [PATCH 4/10] drivers/net/can/flexcan.c: add missing clk_put Julia Lawall
2011-06-01 17:26 ` Joe Perches
2011-06-01 20:08 ` Julia Lawall [this message]
2011-06-01 20:11 ` David Miller
2011-06-01 20:13 ` Julia Lawall
2011-06-02 5:48 ` Julia Lawall
2011-06-02 7:10 ` David Miller
2011-06-01 17:54 ` walter harms
2011-06-01 20:04 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1106012207260.5871@ask.diku.dk \
--to=julia@diku.dk \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=socketcan-core@lists.berlios.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox