From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [bug report] net/mlx5: DR, Move STEv0 setters and getters
Date: Fri, 08 Jan 2021 13:16:31 +0000 [thread overview]
Message-ID: <X/hbL24ZTflzKF09@mwanda> (raw)
Hello Yevgeny Kliteynik,
The patch 6b93b400aa88: "net/mlx5: DR, Move STEv0 setters and
getters" from Nov 19, 2020, leads to the following static checker
warning:
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_ste_v0.c:252 dr_ste_v0_get_miss_addr()
warn: potential shift truncation. '0xff (0-255) << 26'
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_ste_v0.c
248 static u64 dr_ste_v0_get_miss_addr(u8 *hw_ste_p)
249 {
250 u64 index 251 (MLX5_GET(ste_rx_steering_mult, hw_ste_p, miss_address_31_6) |
252 MLX5_GET(ste_rx_steering_mult, hw_ste_p, miss_address_39_32) << 26);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This is shifting a u32 value in the 0-255 range by << 26 which could
result in shift wrapping. "index" is a u64 but ORing two u32 values
will result in a u32.
253
254 return index << 6;
255 }
regards,
dan carpenter
next reply other threads:[~2021-01-08 13:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 13:16 Dan Carpenter [this message]
2021-01-20 0:52 ` [bug report] net/mlx5: DR, Move STEv0 setters and getters Yevgeny Kliteynik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/hbL24ZTflzKF09@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox