Re: [PATCH net-next] net: microchip: sparx5: prevent uninitialized variable

Dan Carpenter
2022-11-17T15:29:41Z

On Thu, Nov 17, 2022 at 04:03:07PM +0100, Paolo Abeni wrote:
> Hello,
>
> On Tue, 2022-11-15 at 16:14 +0300, Dan Carpenter wrote:
> > Smatch complains that:
> >
> > drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c:112
> > sparx5_dcb_apptrust_validate() error: uninitialized symbol 'match'.
> >
> > This would only happen if the:
> >
> > if (sparx5_dcb_apptrust_policies[i].nselectors != nselectors)
> >
> > condition is always true (they are not equal). The "nselectors"
> > variable comes from dcbnl_ieee_set() and it is a number between 0-256.
> > This seems like a probably a real bug.
> >
> > Fixes: 23f8382cd95d ("net: microchip: sparx5: add support for apptrust")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> checkpatch complains about the From/SoB mismatch -
> 'Dan Carpenter <error27@gmail.com>' vs 'Dan Carpenter
> <dan.carpenter@oracle.com>'
>
> Could you please send a v2 addressing that?

Oops. Sorry. Resent.

regards,
dan carpenter