From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Mon, 25 Jan 2021 08:46:03 +0000 Subject: [PATCH] media: i2c: ov5648: remove unnecessary NULL check Message-Id: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mauro Carvalho Chehab , Paul Kocialkowski Cc: Sakari Ailus , linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org The "mode_index = ARRAY_SIZE(ov5648_modes)" check ensures that we exited the loop via a break statement so we know that "mode" must be valid. Delete this unnecessary NULL check. Signed-off-by: Dan Carpenter --- drivers/media/i2c/ov5648.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov5648.c b/drivers/media/i2c/ov5648.c index 609aa67b54ce..b3864be33df2 100644 --- a/drivers/media/i2c/ov5648.c +++ b/drivers/media/i2c/ov5648.c @@ -2337,7 +2337,7 @@ static int ov5648_enum_frame_interval(struct v4l2_subdev *subdev, } } - if (mode_index = ARRAY_SIZE(ov5648_modes) || !mode) + if (mode_index = ARRAY_SIZE(ov5648_modes)) return -EINVAL; switch (interval_enum->code) { -- 2.29.2