public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sergei Krainov <sergei.krainov.lkd@gmail.com>
Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8712: fix wrong function output
Date: Fri, 9 Apr 2021 14:03:01 +0200	[thread overview]
Message-ID: <YHBCdbmPczyK3/0R@kroah.com> (raw)
In-Reply-To: <20210409114159.GA3122@test-VirtualBox>

On Fri, Apr 09, 2021 at 01:41:59PM +0200, Sergei Krainov wrote:
> On Fri, Apr 09, 2021 at 08:33:23AM +0200, Greg KH wrote:
> > On Fri, Apr 09, 2021 at 01:45:27AM +0200, Sergei Krainov wrote:
> > > Function r8712_find_network() were returning wlan_network even if it
> > > didn't match required address. This happened due to not checking if
> > > list end was reached and returning last processed wlan_network.
> > > 
> > > Signed-off-by: Sergei Krainov <sergei.krainov.lkd@gmail.com>
> > > ---
> > >  drivers/staging/rtl8712/rtl871x_mlme.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > 
> > What commit does this "fix"?  Or has this bug been there always?
> > 
> > thanks,
> > 
> > greg k-h
> 
> This commit fixes the bug mentioned. 

What bug mentioned?

> And this commit is based on staging-next and has nothing to do
> with my previous patches, for which I'm sorry, I was wrong.

I do not understand at all, sorry.

Please resend with a "Fixes:" tag that shows the commit that this fixes.

thanks,

greg k-h

      reply	other threads:[~2021-04-09 12:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 23:45 [PATCH] staging: rtl8712: fix wrong function output Sergei Krainov
2021-04-09  6:33 ` Greg KH
2021-04-09 11:41   ` Sergei Krainov
2021-04-09 12:03     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YHBCdbmPczyK3/0R@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=florian.c.schilhabel@googlemail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=sergei.krainov.lkd@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox