From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C6ABC433ED for ; Fri, 14 May 2021 07:08:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D2476140F for ; Fri, 14 May 2021 07:08:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232969AbhENHJV (ORCPT ); Fri, 14 May 2021 03:09:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:50626 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232897AbhENHJU (ORCPT ); Fri, 14 May 2021 03:09:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 899E761354; Fri, 14 May 2021 07:08:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620976090; bh=e5/9R5jIX60oWrB142AU3f1OLRTtCpmN7NsFzFxnRts=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lGSq0YJBbgpsJfs97LaEt5pCjMUd7LLmEzCYM0y9CGssS3JqeoAPkFYHKFkLs7tew 0zh27mH+R15ZK4CAK/izDwRkrL8AqEuVXsj2b6irdssxzdciUTCRnAUTWTfW/cGqqc FHE9SNHiq5YLDYw2pCjGtVbd2A6cBKxxJzzQxySM= Date: Fri, 14 May 2021 09:08:07 +0200 From: Greg Kroah-Hartman To: Qiheng Lin Cc: Arnd Bergmann , zhenwei pi , Andy Shevchenko , Mihai Carabas , Paolo Bonzini , Shile Zhang , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Hulk Robot Subject: Re: [PATCH -next] misc/pvpanic: add missing MODULE_DEVICE_TABLE Message-ID: References: <20210514070103.540-1-linqiheng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210514070103.540-1-linqiheng@huawei.com> Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Fri, May 14, 2021 at 03:01:03PM +0800, Qiheng Lin wrote: > This patch adds missing MODULE_DEVICE_TABLE definition which generates > correct modalias for automatic loading of this driver when it is built > as an external module. > > Reported-by: Hulk Robot > Signed-off-by: Qiheng Lin > --- > drivers/misc/pvpanic/pvpanic-pci.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/misc/pvpanic/pvpanic-pci.c b/drivers/misc/pvpanic/pvpanic-pci.c > index 9ecc4e8559d5..ccd7e32d3f55 100644 > --- a/drivers/misc/pvpanic/pvpanic-pci.c > +++ b/drivers/misc/pvpanic/pvpanic-pci.c > @@ -26,6 +26,7 @@ static const struct pci_device_id pvpanic_pci_id_tbl[] = { > { PCI_DEVICE(PCI_VENDOR_ID_REDHAT, PCI_DEVICE_ID_REDHAT_PVPANIC)}, > {} > }; > +MODULE_DEVICE_TABLE(pci, pvpanic_pci_id_tbl); > > static ssize_t capability_show(struct device *dev, > struct device_attribute *attr, char *buf) > As I have said before, unless you have a user that reports a real problem with these types of modules not automatically loading, I am not going to take these patches, and you should probably stop generating them. thanks, greg k-h