From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
Igor Matheus Andrade Torrente <igormtorrente@gmail.com>,
linux-nvidia@lists.surfsouth.com,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] hgafb: fix probe function
Date: Fri, 21 May 2021 14:54:13 +0200 [thread overview]
Message-ID: <YKetdZTqjOUPQXS8@kroah.com> (raw)
In-Reply-To: <YKIuWEcIJvTIuE2j@mwanda>
On Mon, May 17, 2021 at 11:50:32AM +0300, Dan Carpenter wrote:
> There is a reversed if statement in this probe function so the driver is
> completely broken.
>
> Fixes: dc13cac4862c ("video: hgafb: fix potential NULL pointer dereference")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/video/fbdev/hgafb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/hgafb.c b/drivers/video/fbdev/hgafb.c
> index cc8e62ae93f6..bd3d07aa4f0e 100644
> --- a/drivers/video/fbdev/hgafb.c
> +++ b/drivers/video/fbdev/hgafb.c
> @@ -558,7 +558,7 @@ static int hgafb_probe(struct platform_device *pdev)
> int ret;
>
> ret = hga_card_detect();
> - if (!ret)
> + if (ret)
> return ret;
>
> printk(KERN_INFO "hgafb: %s with %ldK of memory detected.\n",
> --
> 2.30.2
>
Someone _just_ beat you to this:
https://lore.kernel.org/r/20210516192714.25823-1-mail@anirudhrb.com
I'll add your s-o-b to that one as it's identical to yours.
thanks,
greg k-h
prev parent reply other threads:[~2021-05-21 12:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 8:50 [PATCH] hgafb: fix probe function Dan Carpenter
2021-05-21 12:54 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKetdZTqjOUPQXS8@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fero@drama.obuda.kando.hu \
--cc=igormtorrente@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-nvidia@lists.surfsouth.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox