Re: [PATCH 7/7] staging: rtl8188eu: delete some dead code

Guenter Roeck
2021-06-09T10:40:28Z

On Mon, Jun 07, 2021 at 09:19:00PM +0300, Dan Carpenter wrote:
> Calling rtw_free_xmitframe() with a NULL "pxmitframe" parameter is a
> no-op. It appears that originally this code was part of a loop but it
> was already dead code by the time that the driver was merged into the
> kernel.
>
> Fixes: 7bc88639ad36 ("staging: r8188eu: Add files for new driver - part 17")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c b/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c
> index 19055a1a92c1..d82dd22f2903 100644
> --- a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c
> +++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c
> @@ -413,8 +413,7 @@ static u32 xmitframe_need_length(struct xmit_frame *pxmitframe)
> bool rtl8188eu_xmitframe_complete(struct adapter *adapt,
> struct xmit_priv *pxmitpriv)
> {
> - struct xmit_frame *pxmitframe = NULL;
> - struct xmit_frame *n;
> + struct xmit_frame *pxmitframe, *n;
> struct xmit_frame *pfirstframe = NULL;
> struct xmit_buf *pxmitbuf;
>
> @@ -443,8 +442,6 @@ bool rtl8188eu_xmitframe_complete(struct adapter *adapt,
> return false;
>
> /* 3 1. pick up first frame */

Comment could be removed as well. Otherwise,

Thanks a lot for taking care of this, and sorry again for the mess I created.

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> - rtw_free_xmitframe(pxmitpriv, pxmitframe);
> -
> pxmitframe = rtw_dequeue_xframe(pxmitpriv, pxmitpriv->hwxmits, pxmitpriv->hwxmit_entry);
> if (!pxmitframe) {
> /* no more xmit frame, release xmit buffer */
> --
> 2.30.2
>