From: Dan Carpenter <dan.carpenter@oracle.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: David Rivshin <drivshin@allworx.com>,
Jacek Anaszewski <j.anaszewski@samsung.com>,
linux-leds@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] leds: leds-is31fl32xx: fix an error in is31fl32xx_parse_dt()
Date: Sat, 5 Jun 2021 15:49:10 +0300 [thread overview]
Message-ID: <YLtyxq0Ty/7Uo4NS@mwanda> (raw)
Return -EBUSY if the data is already in use (instead of returning
success).
Fixes: 9d7cffaf99f5 ("leds: Add driver for the ISSI IS31FL32xx family of LED controllers")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Not tested. It prints an error so the intention seems clear, but
sometimes making stuff a failure instead of a success can lead to
unexpected problems in production. On the other hand, if this is not
an error then shouldn't we do a continue instead of a goto err?
drivers/leds/leds-is31fl32xx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/leds-is31fl32xx.c b/drivers/leds/leds-is31fl32xx.c
index 3b55af9a8c58..e6f34464914f 100644
--- a/drivers/leds/leds-is31fl32xx.c
+++ b/drivers/leds/leds-is31fl32xx.c
@@ -386,6 +386,7 @@ static int is31fl32xx_parse_dt(struct device *dev,
dev_err(dev,
"Node %pOF 'reg' conflicts with another LED\n",
child);
+ ret = -EBUSY;
goto err;
}
--
2.30.2
next reply other threads:[~2021-06-05 12:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 12:49 Dan Carpenter [this message]
2021-06-07 18:08 ` [PATCH] leds: leds-is31fl32xx: fix an error in is31fl32xx_parse_dt() David Rivshin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLtyxq0Ty/7Uo4NS@mwanda \
--to=dan.carpenter@oracle.com \
--cc=drivshin@allworx.com \
--cc=j.anaszewski@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox