Re: [PATCH net-next] net/mlx5: SF, silence an uninitialized variable warning

Leon Romanovsky
2021-11-28T09:29:04Z

On Sat, Nov 27, 2021 at 05:19:53PM +0300, Dan Carpenter wrote:
> This code sometimes calls mlx5_sf_hw_table_hwc_init() when "ext_base_id"
> is uninitialized. It's not used on that path, but it generates a static
> checker warning to pass uninitialized variables to another function.
> It may also generate runtime UBSan warnings depending on if the
> mlx5_sf_hw_table_hwc_init() function is inlined or not.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/sf/hw_table.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>