From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: Haakon Bugge <haakon.bugge@oracle.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
"arnd@arndb.de" <arnd@arndb.de>,
OFED mailing list <linux-rdma@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] mei: Remove some dead code
Date: Sun, 28 Nov 2021 15:29:22 +0100 [thread overview]
Message-ID: <YaOSQrGqogbFGAqJ@kroah.com> (raw)
In-Reply-To: <17d6896a6abf49138556e34cb426d575@intel.com>
On Sun, Nov 28, 2021 at 11:12:33AM +0000, Winkler, Tomas wrote:
>
> >
> >
> > > On 12 Nov 2021, at 11:06, Christophe JAILLET
> > <christophe.jaillet@wanadoo.fr> wrote:
> > >
> > > 'generated' is known to be true here, so "true || whatever" will still
> > > be true.
> > >
> > > So, remove some dead code.
> > >
> > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > > ---
> > > This is also likely that a bug is lurking here.
> > >
> > > Maybe, the following was expected:
> > > - generated = generated ||
> > > + generated =
> > > (hisr & HISR_INT_STS_MSK) ||
> > > (ipc_isr & SEC_IPC_HOST_INT_STATUS_PENDING);
> > >
> > > ?
> >
> > I concur about your analysis, but I do not know the intent here.
> Your fix is okay, I can ack that patch.
Is that an ack of this patch? If so, please provide that...
thanks,
greg k-h
next prev parent reply other threads:[~2021-11-28 14:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 10:06 [PATCH] mei: Remove some dead code Christophe JAILLET
2021-11-12 11:30 ` Haakon Bugge
2021-11-28 11:12 ` Winkler, Tomas
2021-11-28 14:29 ` gregkh [this message]
2021-11-28 16:38 ` Winkler, Tomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaOSQrGqogbFGAqJ@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=haakon.bugge@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox