kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] misc: rtsx: fix indenting in rts5228_extra_init_hw()
@ 2022-03-07 14:14 Dan Carpenter
  2022-03-18 12:53 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-03-07 14:14 UTC (permalink / raw)
  To: Arnd Bergmann, Ricky WU
  Cc: Greg Kroah-Hartman, Kai-Heng Feng, linux-kernel, kernel-janitors

This code should be indented one more tab.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Introduced in commit 86f4c65fd500 ("misc: rtsx: rts522a rts5228 rts5261
support Runtime PM").  No Fixes tag because it's not a bug.

 drivers/misc/cardreader/rts5228.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/misc/cardreader/rts5228.c b/drivers/misc/cardreader/rts5228.c
index af581f4f74d1..ec97854e1f70 100644
--- a/drivers/misc/cardreader/rts5228.c
+++ b/drivers/misc/cardreader/rts5228.c
@@ -491,9 +491,9 @@ static int rts5228_extra_init_hw(struct rtsx_pcr *pcr)
 
 	if (pcr->rtd3_en) {
 		rtsx_pci_write_register(pcr, pcr->reg_pm_ctrl3, 0x01, 0x01);
-	rtsx_pci_write_register(pcr, RTS5228_REG_PME_FORCE_CTL,
-				FORCE_PM_CONTROL | FORCE_PM_VALUE,
-				FORCE_PM_CONTROL | FORCE_PM_VALUE);
+		rtsx_pci_write_register(pcr, RTS5228_REG_PME_FORCE_CTL,
+					FORCE_PM_CONTROL | FORCE_PM_VALUE,
+					FORCE_PM_CONTROL | FORCE_PM_VALUE);
 	} else {
 		rtsx_pci_write_register(pcr, pcr->reg_pm_ctrl3, 0x01, 0x00);
 		rtsx_pci_write_register(pcr, RTS5228_REG_PME_FORCE_CTL,
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] misc: rtsx: fix indenting in rts5228_extra_init_hw()
  2022-03-07 14:14 [PATCH] misc: rtsx: fix indenting in rts5228_extra_init_hw() Dan Carpenter
@ 2022-03-18 12:53 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2022-03-18 12:53 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Arnd Bergmann, Ricky WU, Kai-Heng Feng, linux-kernel,
	kernel-janitors

On Mon, Mar 07, 2022 at 05:14:21PM +0300, Dan Carpenter wrote:
> This code should be indented one more tab.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Introduced in commit 86f4c65fd500 ("misc: rtsx: rts522a rts5228 rts5261
> support Runtime PM").  No Fixes tag because it's not a bug.
> 
>  drivers/misc/cardreader/rts5228.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/misc/cardreader/rts5228.c b/drivers/misc/cardreader/rts5228.c
> index af581f4f74d1..ec97854e1f70 100644
> --- a/drivers/misc/cardreader/rts5228.c
> +++ b/drivers/misc/cardreader/rts5228.c
> @@ -491,9 +491,9 @@ static int rts5228_extra_init_hw(struct rtsx_pcr *pcr)
>  
>  	if (pcr->rtd3_en) {
>  		rtsx_pci_write_register(pcr, pcr->reg_pm_ctrl3, 0x01, 0x01);
> -	rtsx_pci_write_register(pcr, RTS5228_REG_PME_FORCE_CTL,
> -				FORCE_PM_CONTROL | FORCE_PM_VALUE,
> -				FORCE_PM_CONTROL | FORCE_PM_VALUE);
> +		rtsx_pci_write_register(pcr, RTS5228_REG_PME_FORCE_CTL,
> +					FORCE_PM_CONTROL | FORCE_PM_VALUE,
> +					FORCE_PM_CONTROL | FORCE_PM_VALUE);
>  	} else {
>  		rtsx_pci_write_register(pcr, pcr->reg_pm_ctrl3, 0x01, 0x00);
>  		rtsx_pci_write_register(pcr, RTS5228_REG_PME_FORCE_CTL,
> -- 
> 2.20.1
> 

Someone beat you to it:
	https://lore.kernel.org/r/20220303020206.98911-1-yang.lee@linux.alibaba.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-18 12:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-07 14:14 [PATCH] misc: rtsx: fix indenting in rts5228_extra_init_hw() Dan Carpenter
2022-03-18 12:53 ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).