From: Thierry Reding <thierry.reding@gmail.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: mperttunen@nvidia.com, airlied@gmail.com, daniel@ffwll.ch,
jonathanh@nvidia.com, digetx@gmail.com,
dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 0/6] drm/tegra: Fix some error handling paths
Date: Thu, 14 Dec 2023 18:40:46 +0100 [thread overview]
Message-ID: <ZXs-HmMORtbEKtTB@orome.fritz.box> (raw)
In-Reply-To: <cover.1693667005.git.christophe.jaillet@wanadoo.fr>
[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]
On Sat, Sep 02, 2023 at 05:22:07PM +0200, Christophe JAILLET wrote:
> Most of the patches are retated to tegra_output_probe() and missing
> tegra_output_remove(). Others are things spotted while writting the serie.
>
>
> Patches 1, 3, 4 are verbose, but some functions called in the probe can
> return -EPROBE_DEFER, so it is nice to correctly release resources.
>
> Maybe moving the tegra_output_probe() call would minimize the changes, but I'm
> always reluctant to move code, because of possible side-effects.
>
>
> Christophe JAILLET (6):
> drm/tegra: dsi: Fix some error handling paths in tegra_dsi_probe()
> drm/tegra: dsi: Fix missing pm_runtime_disable() in the error handling
> path of tegra_dsi_probe()
> drm/tegra: dsi: Fix some error handling paths in tegra_hdmi_probe()
> drm/tegra: rgb: Fix some error handling paths in tegra_dc_rgb_probe()
> drm/tegra: rgb: Fix missing clk_put() in the error handling paths of
> tegra_dc_rgb_probe()
> drm/tegra: output: Fix missing i2c_put_adapter() in the error handling
> paths of tegra_output_probe()
>
> drivers/gpu/drm/tegra/dsi.c | 55 ++++++++++++++++++++++------------
> drivers/gpu/drm/tegra/hdmi.c | 20 ++++++++-----
> drivers/gpu/drm/tegra/output.c | 16 +++++++---
> drivers/gpu/drm/tegra/rgb.c | 18 +++++++----
> 4 files changed, 74 insertions(+), 35 deletions(-)
Sorry, this fell through the cracks. Applied now, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-12-14 17:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-02 15:22 [PATCH 0/6] drm/tegra: Fix some error handling paths Christophe JAILLET
2023-09-02 15:22 ` [PATCH 1/6] drm/tegra: dsi: Fix some error handling paths in tegra_dsi_probe() Christophe JAILLET
2023-09-02 15:22 ` [PATCH 2/6] drm/tegra: dsi: Fix missing pm_runtime_disable() in the error handling path of tegra_dsi_probe() Christophe JAILLET
2023-09-02 15:22 ` [PATCH 3/6] drm/tegra: hdmi: Fix some error handling paths in tegra_hdmi_probe() Christophe JAILLET
2023-09-02 15:22 ` [PATCH 4/6] drm/tegra: rgb: Fix some error handling paths in tegra_dc_rgb_probe() Christophe JAILLET
2023-09-02 15:22 ` [PATCH 5/6] drm/tegra: rgb: Fix missing clk_put() in the error handling paths of tegra_dc_rgb_probe() Christophe JAILLET
2023-09-02 15:22 ` [PATCH 6/6] drm/tegra: output: Fix missing i2c_put_adapter() in the error handling paths of tegra_output_probe() Christophe JAILLET
2023-12-14 17:40 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXs-HmMORtbEKtTB@orome.fritz.box \
--to=thierry.reding@gmail.com \
--cc=airlied@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=daniel@ffwll.ch \
--cc=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox