* [PATCH] dm vdo slab-depot: delete unnecessary check
@ 2024-02-09 13:06 Dan Carpenter
2024-02-11 18:29 ` Markus Elfring
2024-02-11 18:55 ` Mike Snitzer
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2024-02-09 13:06 UTC (permalink / raw)
To: Matthew Sakai; +Cc: dm-devel, linux-kernel, kernel-janitors
This is a duplicate check so it can't be true. Delete it.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/md/dm-vdo/slab-depot.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/md/dm-vdo/slab-depot.c b/drivers/md/dm-vdo/slab-depot.c
index 42126bd60242..2f4a2ae5e082 100644
--- a/drivers/md/dm-vdo/slab-depot.c
+++ b/drivers/md/dm-vdo/slab-depot.c
@@ -4100,9 +4100,6 @@ static int allocate_components(struct slab_depot *depot,
};
}
- if (result != VDO_SUCCESS)
- return result;
-
slab_count = vdo_compute_slab_count(depot->first_block, depot->last_block,
depot->slab_size_shift);
if (thread_config->physical_zone_count > slab_count) {
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: dm vdo slab-depot: delete unnecessary check
2024-02-09 13:06 [PATCH] dm vdo slab-depot: delete unnecessary check Dan Carpenter
@ 2024-02-11 18:29 ` Markus Elfring
2024-02-11 18:55 ` Mike Snitzer
1 sibling, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2024-02-11 18:29 UTC (permalink / raw)
To: Dan Carpenter, Matthew Sakai, J. corwin Coburn, Sweet Tea Dorminy,
Mike Snitzer, dm-devel, kernel-janitors
Cc: LKML
> This is a duplicate check
Was this implementation detail detected with any known source code analysis tool?
> so it can't be true. …
I suggest to reconsider this information a bit more.
Would you usually expect the outcome “result == VDO_SUCCESS” from a call
of the function “uds_allocate”?
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: dm vdo slab-depot: delete unnecessary check
2024-02-09 13:06 [PATCH] dm vdo slab-depot: delete unnecessary check Dan Carpenter
2024-02-11 18:29 ` Markus Elfring
@ 2024-02-11 18:55 ` Mike Snitzer
1 sibling, 0 replies; 3+ messages in thread
From: Mike Snitzer @ 2024-02-11 18:55 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Matthew Sakai, dm-devel, linux-kernel, kernel-janitors
On Fri, Feb 09 2024 at 8:06P -0500,
Dan Carpenter <dan.carpenter@linaro.org> wrote:
> This is a duplicate check so it can't be true. Delete it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/md/dm-vdo/slab-depot.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/md/dm-vdo/slab-depot.c b/drivers/md/dm-vdo/slab-depot.c
> index 42126bd60242..2f4a2ae5e082 100644
> --- a/drivers/md/dm-vdo/slab-depot.c
> +++ b/drivers/md/dm-vdo/slab-depot.c
> @@ -4100,9 +4100,6 @@ static int allocate_components(struct slab_depot *depot,
> };
> }
>
> - if (result != VDO_SUCCESS)
> - return result;
> -
> slab_count = vdo_compute_slab_count(depot->first_block, depot->last_block,
> depot->slab_size_shift);
> if (thread_config->physical_zone_count > slab_count) {
> --
> 2.43.0
>
>
Looks good, I've picked this up.
Thanks,
Mike
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-11 18:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-09 13:06 [PATCH] dm vdo slab-depot: delete unnecessary check Dan Carpenter
2024-02-11 18:29 ` Markus Elfring
2024-02-11 18:55 ` Mike Snitzer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).