* [PATCH] xfs: small cleanup in xrep_update_qflags()
@ 2024-03-07 8:39 Dan Carpenter
2024-03-07 15:16 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2024-03-07 8:39 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Chandan Babu R, Dave Chinner, linux-xfs, kernel-janitors
The "mp" pointer is the same as "sc->mp" so this change doesn't affect
runtime at all. However, it's nicer to use same name for both the lock
and the unlock.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
fs/xfs/scrub/repair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/scrub/repair.c b/fs/xfs/scrub/repair.c
index f43dce771cdd..8ee7663fd958 100644
--- a/fs/xfs/scrub/repair.c
+++ b/fs/xfs/scrub/repair.c
@@ -724,7 +724,7 @@ xrep_update_qflags(
xfs_trans_log_buf(sc->tp, bp, 0, sizeof(struct xfs_dsb) - 1);
no_update:
- mutex_unlock(&sc->mp->m_quotainfo->qi_quotaofflock);
+ mutex_unlock(&mp->m_quotainfo->qi_quotaofflock);
}
/* Force a quotacheck the next time we mount. */
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs: small cleanup in xrep_update_qflags()
2024-03-07 8:39 [PATCH] xfs: small cleanup in xrep_update_qflags() Dan Carpenter
@ 2024-03-07 15:16 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2024-03-07 15:16 UTC (permalink / raw)
To: Dan Carpenter
Cc: Darrick J. Wong, Chandan Babu R, Dave Chinner, linux-xfs,
kernel-janitors
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-07 15:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-07 8:39 [PATCH] xfs: small cleanup in xrep_update_qflags() Dan Carpenter
2024-03-07 15:16 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).