From: Phillip Potter <phil@philpotter.co.uk>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Phillip Potter <phil@philpotter.co.uk>,
Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Jeff Johnson <quic_jjohnson@quicinc.com>
Subject: Re: [PATCH] cdrom: Add missing MODULE_DESCRIPTION()
Date: Sat, 1 Jun 2024 22:59:29 +0100 [thread overview]
Message-ID: <ZluYQbvrJkRlhnJC@KernelVM> (raw)
In-Reply-To: <20240530-cdrom-v1-1-51579c5c240a@quicinc.com>
On Thu, May 30, 2024 at 08:23:34PM -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cdrom/cdrom.o
>
> Add the missing MODULE_DESCRIPTION() macro invocation.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> drivers/cdrom/cdrom.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> index 20c90ebb3a3f..b6ee9ae36653 100644
> --- a/drivers/cdrom/cdrom.c
> +++ b/drivers/cdrom/cdrom.c
> @@ -3708,4 +3708,5 @@ static void __exit cdrom_exit(void)
>
> module_init(cdrom_init);
> module_exit(cdrom_exit);
> +MODULE_DESCRIPTION("Uniform CD-ROM driver for Linux");
> MODULE_LICENSE("GPL");
>
> ---
> base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
> change-id: 20240530-cdrom-543cdcf21da4
>
Hi Jeff,
Thank you for the patch, looks good to me. I will send on for inclusion.
Reviewed-by: Phillip Potter <phil@philpotter.co.uk>
Regards,
Phil
prev parent reply other threads:[~2024-06-01 21:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 3:23 [PATCH] cdrom: Add missing MODULE_DESCRIPTION() Jeff Johnson
2024-06-01 21:59 ` Phillip Potter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZluYQbvrJkRlhnJC@KernelVM \
--to=phil@philpotter.co.uk \
--cc=axboe@kernel.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).