* [PATCH] cdrom: Add missing MODULE_DESCRIPTION()
@ 2024-05-31 3:23 Jeff Johnson
2024-06-01 21:59 ` Phillip Potter
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Johnson @ 2024-05-31 3:23 UTC (permalink / raw)
To: Phillip Potter, Jens Axboe; +Cc: linux-kernel, kernel-janitors, Jeff Johnson
make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cdrom/cdrom.o
Add the missing MODULE_DESCRIPTION() macro invocation.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
drivers/cdrom/cdrom.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
index 20c90ebb3a3f..b6ee9ae36653 100644
--- a/drivers/cdrom/cdrom.c
+++ b/drivers/cdrom/cdrom.c
@@ -3708,4 +3708,5 @@ static void __exit cdrom_exit(void)
module_init(cdrom_init);
module_exit(cdrom_exit);
+MODULE_DESCRIPTION("Uniform CD-ROM driver for Linux");
MODULE_LICENSE("GPL");
---
base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
change-id: 20240530-cdrom-543cdcf21da4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cdrom: Add missing MODULE_DESCRIPTION()
2024-05-31 3:23 [PATCH] cdrom: Add missing MODULE_DESCRIPTION() Jeff Johnson
@ 2024-06-01 21:59 ` Phillip Potter
0 siblings, 0 replies; 2+ messages in thread
From: Phillip Potter @ 2024-06-01 21:59 UTC (permalink / raw)
To: Jeff Johnson
Cc: Phillip Potter, Jens Axboe, linux-kernel, kernel-janitors,
Jeff Johnson
On Thu, May 30, 2024 at 08:23:34PM -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cdrom/cdrom.o
>
> Add the missing MODULE_DESCRIPTION() macro invocation.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> drivers/cdrom/cdrom.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> index 20c90ebb3a3f..b6ee9ae36653 100644
> --- a/drivers/cdrom/cdrom.c
> +++ b/drivers/cdrom/cdrom.c
> @@ -3708,4 +3708,5 @@ static void __exit cdrom_exit(void)
>
> module_init(cdrom_init);
> module_exit(cdrom_exit);
> +MODULE_DESCRIPTION("Uniform CD-ROM driver for Linux");
> MODULE_LICENSE("GPL");
>
> ---
> base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
> change-id: 20240530-cdrom-543cdcf21da4
>
Hi Jeff,
Thank you for the patch, looks good to me. I will send on for inclusion.
Reviewed-by: Phillip Potter <phil@philpotter.co.uk>
Regards,
Phil
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-01 21:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-31 3:23 [PATCH] cdrom: Add missing MODULE_DESCRIPTION() Jeff Johnson
2024-06-01 21:59 ` Phillip Potter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).