From: "Milan P. Gandhi" <mgandhi@redhat.com>
To: linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
Johannes Thumshirn <jth@kernel.org>,
Laurence Oberman <loberman@redhat.com>
Subject: [PATCH] Eliminate extra 'out_free' label from fcoe_init function
Date: Thu, 01 Jun 2017 12:23:06 +0000 [thread overview]
Message-ID: <a1ea0104-83ed-2249-3450-dc5c31517558@redhat.com> (raw)
Simplify the check for return code of fcoe_if_init routine
in fcoe_init function such that we could eliminate need for
extra 'out_free' label.
Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com>
---
drivers/scsi/fcoe/fcoe.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index ea21e7b..fb2a4c9 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -2523,13 +2523,11 @@ static int __init fcoe_init(void)
fcoe_dev_setup();
rc = fcoe_if_init();
- if (rc)
- goto out_free;
-
- mutex_unlock(&fcoe_config_mutex);
- return 0;
+ if (rc = 0) {
+ mutex_unlock(&fcoe_config_mutex);
+ return 0;
+ }
-out_free:
mutex_unlock(&fcoe_config_mutex);
out_destroy:
destroy_workqueue(fcoe_wq);
next reply other threads:[~2017-06-01 12:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 12:23 Milan P. Gandhi [this message]
2017-06-01 13:07 ` [PATCH] Eliminate extra 'out_free' label from fcoe_init function Johannes Thumshirn
2017-06-01 15:02 ` Dan Carpenter
2017-06-02 3:47 ` Milan P. Gandhi
2017-06-02 5:49 ` Julia Lawall
2017-06-02 12:45 ` Milan P. Gandhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1ea0104-83ed-2249-3450-dc5c31517558@redhat.com \
--to=mgandhi@redhat.com \
--cc=jth@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=loberman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox