From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Joe Perches <joe@perches.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Wolfram Sang <wsa@the-dreams.de>,
Haiyang Zhang <haiyangz@microsoft.com>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
devel@linuxdriverproject.org
Subject: Re: Clarification for general change acceptance
Date: Fri, 12 May 2017 08:23:37 +0000 [thread overview]
Message-ID: <a348c5f5-d2fd-0d30-f579-a5939eab2f2b@users.sourceforge.net> (raw)
In-Reply-To: <1494575540.2028.17.camel@perches.com>
> Developer reputation matters for somewhat controversial
> patches being applied as well as non-controversial and
> obviously correct patches being ignored.
I am aware that there are more factors involved.
> Your reputation means most all of your patches fall into
> the latter category.
I hope that this situation will evolve into directions which you would prefer more.
> You have produced many trivial patches
This is true.
I started my concrete contributions to Linux software modules with simple
source code search patterns.
> that have caused new defects.
A few unwanted programming mistakes just happened somehow.
> That is simply unacceptable.
Glitches are not desired as usual.
> Especially when you don't immediately fix the problems you cause.
I find my response times reasonable to some degree so far.
Remaining open issues can be clarified by a corresponding constructive
development dialogue, can't they?
> If you would stop producing the trivial and instead
> channel your efforts into actual bug fixing and logic
> corrections and not just style modifications with no
> code impact, your patch acceptance rate would increase.
I find your conclusion appropriate.
But I will come along source code places where I am going to update details
which are also trivial.
> I have given you many suggestions for actual structural
> improvements to kernel code.
I have got an other impression. There were a few occasions where advanced
change possibilities were proposed.
> You have ignored _all_ of them and I am unlikely to try
> to interact with you any longer until your wheat:chaff
> ratio changes.
Can the efforts for deleting questionable error messages around Linux memory
allocation functions improve this situation?
Regards,
Markus
next prev parent reply other threads:[~2017-05-12 8:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 16:14 [PATCH 0/4] VMBus: Adjustments for some function implementations SF Markus Elfring
2017-05-11 16:15 ` [PATCH 1/4] vmbus: Improve a size determination in vmbus_device_create() SF Markus Elfring
2017-05-11 16:30 ` Stephen Hemminger
2017-05-11 17:47 ` Greg KH
2017-05-11 16:17 ` [PATCH 2/4] vmbus: Delete an error message for a failed memory allocation " SF Markus Elfring
2017-05-11 16:30 ` [PATCH 2/4] vmbus: Delete an error message for a failed memory allocation in vmbus_device_create Stephen Hemminger
2017-05-11 16:36 ` vmbus: Delete an error message for a failed memory allocation in vmbus_device_create() SF Markus Elfring
2017-05-11 16:42 ` Stephen Hemminger
2017-05-12 7:09 ` [PATCH 2/4] vmbus: Delete an error message for a failed memory allocation in vmbus_device_create Dan Carpenter
2017-05-12 7:32 ` vmbus: Delete an error message for a failed memory allocation in vmbus_device_create() SF Markus Elfring
2017-05-12 7:52 ` Joe Perches
2017-05-12 8:23 ` SF Markus Elfring [this message]
2017-05-12 8:37 ` Clarification for general change acceptance Julia Lawall
2017-05-12 8:45 ` SF Markus Elfring
2017-05-11 16:18 ` [PATCH 3/4] vmbus: Fix a typo in a comment line SF Markus Elfring
2017-05-11 16:33 ` Stephen Hemminger
2017-05-11 16:19 ` [PATCH 4/4] vmbus: Adjust five checks for null pointers SF Markus Elfring
2017-05-11 16:34 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a348c5f5-d2fd-0d30-f579-a5939eab2f2b@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox