Re: [PATCH] kvm: x86: hyperv: delete dead code in kvm_hv_hypercall()

Liran Alon
2018-03-17T15:11:42Z

----- dan.carpenter@oracle.com wrote:

> "rep_done" is always zero so the "(((u64)rep_done & 0xfff) << 32)"
> expression is just zero. We can remove the "res" temporary variable
> as
> well and just use "ret" directly.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>

I think this commit should better be dropped than applied.
The original code makes sense.
It will make it easier to implement an hyper-v rep hypercall (which require rep_done).
I don't think it makes current code much more complicated than it is without it.

-Liran