* [PATCH next] drm/xe: Fix a NULL vs IS_ERR() bug in xe_i2c_register_adapter()
@ 2025-07-15 22:59 Dan Carpenter
2025-07-16 14:50 ` Rodrigo Vivi
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2025-07-15 22:59 UTC (permalink / raw)
To: Heikki Krogerus
Cc: Lucas De Marchi, Thomas Hellström, Rodrigo Vivi,
David Airlie, Simona Vetter, Michael J. Ruhl, Andi Shyti,
intel-xe, dri-devel, linux-kernel, kernel-janitors
The fwnode_create_software_node() function returns error pointers. It
never returns NULL. Update the checks to match.
Fixes: f0e53aadd702 ("drm/xe: Support for I2C attached MCUs")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/gpu/drm/xe/xe_i2c.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_i2c.c b/drivers/gpu/drm/xe/xe_i2c.c
index db9c0340be5c..1f19718db559 100644
--- a/drivers/gpu/drm/xe/xe_i2c.c
+++ b/drivers/gpu/drm/xe/xe_i2c.c
@@ -96,8 +96,8 @@ static int xe_i2c_register_adapter(struct xe_i2c *i2c)
int ret;
fwnode = fwnode_create_software_node(xe_i2c_adapter_properties, NULL);
- if (!fwnode)
- return -ENOMEM;
+ if (IS_ERR(fwnode))
+ return PTR_ERR(fwnode);
/*
* Not using platform_device_register_full() here because we don't have
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH next] drm/xe: Fix a NULL vs IS_ERR() bug in xe_i2c_register_adapter()
2025-07-15 22:59 [PATCH next] drm/xe: Fix a NULL vs IS_ERR() bug in xe_i2c_register_adapter() Dan Carpenter
@ 2025-07-16 14:50 ` Rodrigo Vivi
0 siblings, 0 replies; 2+ messages in thread
From: Rodrigo Vivi @ 2025-07-16 14:50 UTC (permalink / raw)
To: Dan Carpenter
Cc: Heikki Krogerus, Lucas De Marchi, Thomas Hellström,
David Airlie, Simona Vetter, Michael J. Ruhl, Andi Shyti,
intel-xe, dri-devel, linux-kernel, kernel-janitors
On Tue, Jul 15, 2025 at 05:59:44PM -0500, Dan Carpenter wrote:
> The fwnode_create_software_node() function returns error pointers. It
> never returns NULL. Update the checks to match.
>
> Fixes: f0e53aadd702 ("drm/xe: Support for I2C attached MCUs")
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
and pushing soon
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/gpu/drm/xe/xe_i2c.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_i2c.c b/drivers/gpu/drm/xe/xe_i2c.c
> index db9c0340be5c..1f19718db559 100644
> --- a/drivers/gpu/drm/xe/xe_i2c.c
> +++ b/drivers/gpu/drm/xe/xe_i2c.c
> @@ -96,8 +96,8 @@ static int xe_i2c_register_adapter(struct xe_i2c *i2c)
> int ret;
>
> fwnode = fwnode_create_software_node(xe_i2c_adapter_properties, NULL);
> - if (!fwnode)
> - return -ENOMEM;
> + if (IS_ERR(fwnode))
> + return PTR_ERR(fwnode);
>
> /*
> * Not using platform_device_register_full() here because we don't have
> --
> 2.47.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-16 14:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-15 22:59 [PATCH next] drm/xe: Fix a NULL vs IS_ERR() bug in xe_i2c_register_adapter() Dan Carpenter
2025-07-16 14:50 ` Rodrigo Vivi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox