* [PATCH next] drm/bridge: synopsys: Fix an error return in dw_dp_video_need_vsc_sdp()
@ 2025-09-02 6:33 Dan Carpenter
2025-09-02 8:42 ` Andy Yan
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2025-09-02 6:33 UTC (permalink / raw)
To: Andy Yan
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Dmitry Baryshkov,
dri-devel, linux-kernel, kernel-janitors
This dw_dp_video_need_vsc_sdp() function is type bool so returning
-EINVAL means returning true. Return false instead.
Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
index 9bbfe8da3de0..33be4eae2b20 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
@@ -1149,7 +1149,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp)
state = dw_dp_get_bridge_state(dp);
if (!state)
- return -EINVAL;
+ return false;
if (!link->vsc_sdp_supported)
return false;
--
2.47.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re:[PATCH next] drm/bridge: synopsys: Fix an error return in dw_dp_video_need_vsc_sdp()
2025-09-02 6:33 [PATCH next] drm/bridge: synopsys: Fix an error return in dw_dp_video_need_vsc_sdp() Dan Carpenter
@ 2025-09-02 8:42 ` Andy Yan
2025-10-14 8:13 ` [PATCH " Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Andy Yan @ 2025-09-02 8:42 UTC (permalink / raw)
To: Dan Carpenter
Cc: Andy Yan, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Dmitry Baryshkov, dri-devel, linux-kernel,
kernel-janitors
Hello Dan,
At 2025-09-02 14:33:44, "Dan Carpenter" <dan.carpenter@linaro.org> wrote:
>This dw_dp_video_need_vsc_sdp() function is type bool so returning
>-EINVAL means returning true. Return false instead.
>
>Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library")
>Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Andy Yan <andyshrk@163.com>
>---
> drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
>index 9bbfe8da3de0..33be4eae2b20 100644
>--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
>+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
>@@ -1149,7 +1149,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp)
>
> state = dw_dp_get_bridge_state(dp);
> if (!state)
>- return -EINVAL;
>+ return false;
>
> if (!link->vsc_sdp_supported)
> return false;
>--
>2.47.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH next] drm/bridge: synopsys: Fix an error return in dw_dp_video_need_vsc_sdp()
2025-09-02 8:42 ` Andy Yan
@ 2025-10-14 8:13 ` Dan Carpenter
2026-01-22 6:05 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2025-10-14 8:13 UTC (permalink / raw)
To: Andy Yan
Cc: Andy Yan, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Dmitry Baryshkov, dri-devel, linux-kernel,
kernel-janitors
On Tue, Sep 02, 2025 at 04:42:41PM +0800, Andy Yan wrote:
>
> Hello Dan,
>
> At 2025-09-02 14:33:44, "Dan Carpenter" <dan.carpenter@linaro.org> wrote:
> >This dw_dp_video_need_vsc_sdp() function is type bool so returning
> >-EINVAL means returning true. Return false instead.
> >
> >Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library")
> >Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
>
>
> Reviewed-by: Andy Yan <andyshrk@163.com>
>
Ping?
regards,
dan carpenter
>
> >---
> > drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
> >index 9bbfe8da3de0..33be4eae2b20 100644
> >--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
> >+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
> >@@ -1149,7 +1149,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp)
> >
> > state = dw_dp_get_bridge_state(dp);
> > if (!state)
> >- return -EINVAL;
> >+ return false;
> >
> > if (!link->vsc_sdp_supported)
> > return false;
> >--
> >2.47.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH next] drm/bridge: synopsys: Fix an error return in dw_dp_video_need_vsc_sdp()
2025-10-14 8:13 ` [PATCH " Dan Carpenter
@ 2026-01-22 6:05 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2026-01-22 6:05 UTC (permalink / raw)
To: Andy Yan
Cc: Andy Yan, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Dmitry Baryshkov, dri-devel, linux-kernel,
kernel-janitors
Ping again?
regards,
dan carpenter
On Tue, Oct 14, 2025 at 11:13:15AM +0300, Dan Carpenter wrote:
> On Tue, Sep 02, 2025 at 04:42:41PM +0800, Andy Yan wrote:
> >
> > Hello Dan,
> >
> > At 2025-09-02 14:33:44, "Dan Carpenter" <dan.carpenter@linaro.org> wrote:
> > >This dw_dp_video_need_vsc_sdp() function is type bool so returning
> > >-EINVAL means returning true. Return false instead.
> > >
> > >Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library")
> > >Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> >
> >
> > Reviewed-by: Andy Yan <andyshrk@163.com>
> >
>
> Ping?
>
> regards,
> dan carpenter
>
> >
> > >---
> > > drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > >diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
> > >index 9bbfe8da3de0..33be4eae2b20 100644
> > >--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
> > >+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
> > >@@ -1149,7 +1149,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp)
> > >
> > > state = dw_dp_get_bridge_state(dp);
> > > if (!state)
> > >- return -EINVAL;
> > >+ return false;
> > >
> > > if (!link->vsc_sdp_supported)
> > > return false;
> > >--
> > >2.47.2
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-01-22 6:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-02 6:33 [PATCH next] drm/bridge: synopsys: Fix an error return in dw_dp_video_need_vsc_sdp() Dan Carpenter
2025-09-02 8:42 ` Andy Yan
2025-10-14 8:13 ` [PATCH " Dan Carpenter
2026-01-22 6:05 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox