From: Dan Carpenter <dan.carpenter@linaro.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Liao Yuanhong <liaoyuanhong@vivo.com>,
Hans Verkuil <hverkuil+cisco@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [PATCH] media: dvb-frontends: drx39xyj: clean up some sanity checking
Date: Sat, 1 Nov 2025 16:25:19 +0300 [thread overview]
Message-ID: <aQYKP330_-4LBa7E@stanley.mountain> (raw)
Delete the duplicate check on "demod->my_ext_attr == NULL" and delete
the unnecessary curly braces.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/media/dvb-frontends/drx39xyj/drxj.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/media/dvb-frontends/drx39xyj/drxj.c b/drivers/media/dvb-frontends/drx39xyj/drxj.c
index 428b31e60874..57bd5d53339a 100644
--- a/drivers/media/dvb-frontends/drx39xyj/drxj.c
+++ b/drivers/media/dvb-frontends/drx39xyj/drxj.c
@@ -11350,12 +11350,7 @@ static int drxj_open(struct drx_demod_instance *demod)
(demod->my_common_attr == NULL) ||
(demod->my_ext_attr == NULL) ||
(demod->my_i2c_dev_addr == NULL) ||
- (demod->my_common_attr->is_opened)) {
- return -EINVAL;
- }
-
- /* Check arguments */
- if (demod->my_ext_attr == NULL)
+ (demod->my_common_attr->is_opened))
return -EINVAL;
dev_addr = demod->my_i2c_dev_addr;
--
2.51.0
reply other threads:[~2025-11-01 13:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQYKP330_-4LBa7E@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=hverkuil+cisco@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=liaoyuanhong@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox