kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] media: dvb-frontends: drx39xyj: clean up some sanity checking
@ 2025-11-01 13:25 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2025-11-01 13:25 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Liao Yuanhong, Hans Verkuil, linux-media, linux-kernel,
	kernel-janitors

Delete the duplicate check on "demod->my_ext_attr == NULL" and delete
the unnecessary curly braces.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/media/dvb-frontends/drx39xyj/drxj.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/media/dvb-frontends/drx39xyj/drxj.c b/drivers/media/dvb-frontends/drx39xyj/drxj.c
index 428b31e60874..57bd5d53339a 100644
--- a/drivers/media/dvb-frontends/drx39xyj/drxj.c
+++ b/drivers/media/dvb-frontends/drx39xyj/drxj.c
@@ -11350,12 +11350,7 @@ static int drxj_open(struct drx_demod_instance *demod)
 	    (demod->my_common_attr == NULL) ||
 	    (demod->my_ext_attr == NULL) ||
 	    (demod->my_i2c_dev_addr == NULL) ||
-	    (demod->my_common_attr->is_opened)) {
-		return -EINVAL;
-	}
-
-	/* Check arguments */
-	if (demod->my_ext_attr == NULL)
+	    (demod->my_common_attr->is_opened))
 		return -EINVAL;
 
 	dev_addr = demod->my_i2c_dev_addr;
-- 
2.51.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2025-11-01 13:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-01 13:25 [PATCH] media: dvb-frontends: drx39xyj: clean up some sanity checking Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).