* [PATCH next] remoteproc: imx_dsp_rproc: Fix NULL vs IS_ERR() bug in imx_dsp_rproc_add_carveout()
@ 2025-11-27 7:14 Dan Carpenter
2025-11-27 7:48 ` Iuliana Prodan
2025-11-27 16:02 ` Mathieu Poirier
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2025-11-27 7:14 UTC (permalink / raw)
To: Rob Herring
Cc: Bjorn Andersson, Mathieu Poirier, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Geert Uytterhoeven,
Arnaud Pouliquen, linux-remoteproc, imx, linux-arm-kernel,
linux-kernel, kernel-janitors
The devm_ioremap_resource_wc() function never returns NULL, it returns
error pointers. Update the error checking to match.
Fixes: 67a7bc7f0358 ("remoteproc: Use of_reserved_mem_region_* functions for "memory-region"")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/remoteproc/imx_dsp_rproc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c
index be83b5f20f15..5130a35214c9 100644
--- a/drivers/remoteproc/imx_dsp_rproc.c
+++ b/drivers/remoteproc/imx_dsp_rproc.c
@@ -710,9 +710,9 @@ static int imx_dsp_rproc_add_carveout(struct imx_dsp_rproc *priv)
return -EINVAL;
cpu_addr = devm_ioremap_resource_wc(dev, &res);
- if (!cpu_addr) {
+ if (IS_ERR(cpu_addr)) {
dev_err(dev, "failed to map memory %pR\n", &res);
- return -ENOMEM;
+ return PTR_ERR(cpu_addr);
}
/* Register memory region */
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH next] remoteproc: imx_dsp_rproc: Fix NULL vs IS_ERR() bug in imx_dsp_rproc_add_carveout()
2025-11-27 7:14 [PATCH next] remoteproc: imx_dsp_rproc: Fix NULL vs IS_ERR() bug in imx_dsp_rproc_add_carveout() Dan Carpenter
@ 2025-11-27 7:48 ` Iuliana Prodan
2025-11-27 16:02 ` Mathieu Poirier
1 sibling, 0 replies; 3+ messages in thread
From: Iuliana Prodan @ 2025-11-27 7:48 UTC (permalink / raw)
To: Dan Carpenter, Rob Herring
Cc: Bjorn Andersson, Mathieu Poirier, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Geert Uytterhoeven,
Arnaud Pouliquen, linux-remoteproc, imx, linux-arm-kernel,
linux-kernel, kernel-janitors
On 11/27/2025 9:14 AM, Dan Carpenter wrote:
> The devm_ioremap_resource_wc() function never returns NULL, it returns
> error pointers. Update the error checking to match.
>
> Fixes: 67a7bc7f0358 ("remoteproc: Use of_reserved_mem_region_* functions for "memory-region"")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>
Thanks,
Iulia
> ---
> drivers/remoteproc/imx_dsp_rproc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c
> index be83b5f20f15..5130a35214c9 100644
> --- a/drivers/remoteproc/imx_dsp_rproc.c
> +++ b/drivers/remoteproc/imx_dsp_rproc.c
> @@ -710,9 +710,9 @@ static int imx_dsp_rproc_add_carveout(struct imx_dsp_rproc *priv)
> return -EINVAL;
>
> cpu_addr = devm_ioremap_resource_wc(dev, &res);
> - if (!cpu_addr) {
> + if (IS_ERR(cpu_addr)) {
> dev_err(dev, "failed to map memory %pR\n", &res);
> - return -ENOMEM;
> + return PTR_ERR(cpu_addr);
> }
>
> /* Register memory region */
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH next] remoteproc: imx_dsp_rproc: Fix NULL vs IS_ERR() bug in imx_dsp_rproc_add_carveout()
2025-11-27 7:14 [PATCH next] remoteproc: imx_dsp_rproc: Fix NULL vs IS_ERR() bug in imx_dsp_rproc_add_carveout() Dan Carpenter
2025-11-27 7:48 ` Iuliana Prodan
@ 2025-11-27 16:02 ` Mathieu Poirier
1 sibling, 0 replies; 3+ messages in thread
From: Mathieu Poirier @ 2025-11-27 16:02 UTC (permalink / raw)
To: Dan Carpenter
Cc: Rob Herring, Bjorn Andersson, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Geert Uytterhoeven,
Arnaud Pouliquen, linux-remoteproc, imx, linux-arm-kernel,
linux-kernel, kernel-janitors
On Thu, Nov 27, 2025 at 10:14:01AM +0300, Dan Carpenter wrote:
> The devm_ioremap_resource_wc() function never returns NULL, it returns
> error pointers. Update the error checking to match.
>
> Fixes: 67a7bc7f0358 ("remoteproc: Use of_reserved_mem_region_* functions for "memory-region"")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/remoteproc/imx_dsp_rproc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c
> index be83b5f20f15..5130a35214c9 100644
> --- a/drivers/remoteproc/imx_dsp_rproc.c
> +++ b/drivers/remoteproc/imx_dsp_rproc.c
> @@ -710,9 +710,9 @@ static int imx_dsp_rproc_add_carveout(struct imx_dsp_rproc *priv)
> return -EINVAL;
>
> cpu_addr = devm_ioremap_resource_wc(dev, &res);
> - if (!cpu_addr) {
> + if (IS_ERR(cpu_addr)) {
> dev_err(dev, "failed to map memory %pR\n", &res);
> - return -ENOMEM;
> + return PTR_ERR(cpu_addr);
Applied.
Thanks,
Mathieu
> }
>
> /* Register memory region */
> --
> 2.51.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-27 16:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-27 7:14 [PATCH next] remoteproc: imx_dsp_rproc: Fix NULL vs IS_ERR() bug in imx_dsp_rproc_add_carveout() Dan Carpenter
2025-11-27 7:48 ` Iuliana Prodan
2025-11-27 16:02 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).