From: Dan Carpenter <dan.carpenter@linaro.org>
To: Zilin Guan <zilin@seu.edu.cn>
Cc: markus.elfring@web.de, James.Bottomley@hansenpartnership.com,
jianhao.xu@seu.edu.cn, justin.tee@broadcom.com,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
paul.ely@broadcom.com
Subject: Re: [PATCH 1/3] scsi: lpfc: Fix memory leak in lpfc_config_port_post()
Date: Mon, 5 Jan 2026 13:17:54 +0300 [thread overview]
Message-ID: <aVuP0lJxn2pc6cNa@stanley.mountain> (raw)
In-Reply-To: <aVuKJPNjNyt3_yEV@stanley.mountain>
On Mon, Jan 05, 2026 at 12:53:40PM +0300, Dan Carpenter wrote:
> On Tue, Dec 30, 2025 at 06:20:08AM +0000, Zilin Guan wrote:
> > On Mon, Dec 29, 2025 at 10:09:04AM +0100, Markus Elfring wrote:
> > > …
> > > > Fix this by adding mempool_free() in the error path.
> > >
> > > Please avoid duplicate source code here.
> > > https://elixir.bootlin.com/linux/v6.19-rc2/source/drivers/scsi/lpfc/lpfc_init.c#L563-L564
> >
> > Thanks for pointing this out. I will use a goto label to unify the error
> > handling logic and avoid code duplication in v2.
> >
> > > See also:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc3#n262
> > >
> > > Regards,
> > > Markus
> >
> > Regarding the stable kernel rules, do you consider this bug severe enough
> > to warrant a Cc: stable tag? Since this error path is unlikely to be
> > triggered during normal operation and the leak is small, I didn't think
> > it was critical enough to bother the stable maintainers.
>
> I don't agree with either of Markus's review comments. People have
> asked him to stop reviewing code or at least to stick to pointing out
> bugs or complaining about style and grammar issues but he doesn't
> listen.
I meant "or at least stop complaining about style and grammar issues".
regards,
dan carpenter
prev parent reply other threads:[~2026-01-05 10:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251229071515.155412-2-zilin@seu.edu.cn>
2025-12-29 9:09 ` [PATCH 1/3] scsi: lpfc: Fix memory leak in lpfc_config_port_post() Markus Elfring
2025-12-30 6:20 ` Zilin Guan
2025-12-30 7:28 ` [1/3] " Markus Elfring
2025-12-30 9:05 ` Zilin Guan
2026-01-05 9:53 ` [PATCH 1/3] " Dan Carpenter
2026-01-05 10:17 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVuP0lJxn2pc6cNa@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=jianhao.xu@seu.edu.cn \
--cc=justin.tee@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=markus.elfring@web.de \
--cc=martin.petersen@oracle.com \
--cc=paul.ely@broadcom.com \
--cc=zilin@seu.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox