From: Yohei Kojima <yk@y-koj.net>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shuah Khan <shuah@kernel.org>, Simon Horman <horms@kernel.org>
Subject: Re: [PATCH net-next v2 2/2] selftests: net: improve error handling in passive TFO test
Date: Fri, 16 Jan 2026 01:21:00 +0900 [thread overview]
Message-ID: <aWkRvBz734sa_1vV@desktop.y-koj.net> (raw)
In-Reply-To: <1696424e-2092-4e47-bd4f-293e2992056b@web.de>
On Wed, Jan 14, 2026 at 09:33:12AM +0100, Markus Elfring wrote:
> > Improve the error handling in passive TFO test to check the return value
> > from sendto(), and to fail if read() or fprintf() failed.
>
> You propose to adjust error detection and corresponding exception handling another bit.
> How do you think about to take also another look if further function implementations
> would be similarly affected?
Thank you for the suggestion. The first objective of this series is to
fix the misleading behavior that was caused by the following bug.
Therefore, I intentionally limited the scope of this patch to the
affected or closely related functions.
https://lore.kernel.org/netdev/602c9e1ba5bb2ee1997bb38b1d866c9c3b807ae9.1767624906.git.yk@y-koj.net/
I believe this is sufficient to prevent it from showing misleading error
messages when the test fails.
Thank you,
Yohei
>
> Regards,
> Markus
prev parent reply other threads:[~2026-01-15 16:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1768312014.git.yk@y-koj.net>
[not found] ` <24707c8133f7095c0e5a94afa69e75c3a80bf6e7.1768312014.git.yk@y-koj.net>
2026-01-14 8:33 ` [PATCH net-next v2 2/2] selftests: net: improve error handling in passive TFO test Markus Elfring
2026-01-15 16:21 ` Yohei Kojima [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWkRvBz734sa_1vV@desktop.y-koj.net \
--to=yk@y-koj.net \
--cc=Markus.Elfring@web.de \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox