Re: [PATCH v3 next 2/6] iio: sca3000: reuse device pointer for devm helpers

Andy Shevchenko
2026-02-03T15:17:24Z

On Tue, Feb 03, 2026 at 04:20:46AM -0800, Harshit Mogalapalli wrote:
> Cache struct device *dev and feed it to the devm helpers to simplify
> the probe function. No functional changes.

With or without below being addressed,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

...

> - ret = devm_iio_kfifo_buffer_setup(&spi->dev, indio_dev,
> + ret = devm_iio_kfifo_buffer_setup(dev, indio_dev,
> &sca3000_ring_setup_ops);

Now make it a single line, it's just 83 characters.

> if (ret)

--
With Best Regards,
Andy Shevchenko