Re: [PATCH v3 next 1/6] iio: sca3000: cache SPI device ID in probe

Harshit Mogalapalli
2026-02-03T15:55:28Z

Hi Andy,

On 03/02/26 20:49, Andy Shevchenko wrote:
> On Tue, Feb 03, 2026 at 04:20:45AM -0800, Harshit Mogalapalli wrote:
>> Store the spi_device_id at probe entry and reuse it for the name and
>> chip info instead of calling spi_get_device_id() repeatedly.
>>
>> While at it, reshuffle variable list in a reverse Christmas tree
>> order. No functional change intended.
>
> Did you miss David's comment? AFAIU the suggestion was to convert to
> chip_info(). With that done, this should use spi_device_get_match_data()
> (or something like that, I don't remember the correct spelling of that API).
>

I was thinking of dealing with it in a separate series(as documented in
the cover letter). Also David pointed out that if I am planning to do
that conversion separate, there is no neccesity of this patch, as it is
anyway going to be replaced soon when I have that ready. So I will drop
this simplification in my next version and leave the conversion to
spi_device_get_match_data() to another patch set. Will also include your
"irq > 0" check fixup in the following series. Hope you are okay with that ?

Thanks a lot for the review!

Regards,
Harshit