From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Andrew Ijano" <andrew.ijano@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, error27@gmail.com,
"David Lechner" <dlechner@baylibe.com>
Subject: Re: [PATCH v3 next 3/6] iio: sca3000: switch IRQ handling to devm helpers
Date: Tue, 3 Feb 2026 17:20:40 +0200 [thread overview]
Message-ID: <aYISSJLM5CxUXlQv@smile.fi.intel.com> (raw)
In-Reply-To: <20260203122109.689669-4-harshit.m.mogalapalli@oracle.com>
On Tue, Feb 03, 2026 at 04:20:47AM -0800, Harshit Mogalapalli wrote:
> Convert the threaded IRQ registration to devm_request_threaded_irq() so
> that the probe and remove paths can drop manual freeing of irqs.
...
> if (spi->irq) {
Hmm, shouldn't this be ' > 0' check?
> - ret = request_threaded_irq(spi->irq,
> - NULL,
> - &sca3000_event_handler,
> - IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> - "sca3000",
> - indio_dev);
> + ret = devm_request_threaded_irq(dev, spi->irq, NULL,
> + &sca3000_event_handler,
> + IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> + "sca3000",
> + indio_dev);
> if (ret)
> return ret;
> }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-03 15:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 12:20 [PATCH v3 next 0/6] IIO: sca3000: devm resource management Harshit Mogalapalli
2026-02-03 12:20 ` [PATCH v3 next 1/6] iio: sca3000: cache SPI device ID in probe Harshit Mogalapalli
2026-02-03 15:19 ` Andy Shevchenko
2026-02-03 15:55 ` Harshit Mogalapalli
2026-02-03 17:54 ` Andy Shevchenko
2026-02-03 12:20 ` [PATCH v3 next 2/6] iio: sca3000: reuse device pointer for devm helpers Harshit Mogalapalli
2026-02-03 15:17 ` Andy Shevchenko
2026-02-03 15:59 ` Harshit Mogalapalli
2026-02-03 12:20 ` [PATCH v3 next 3/6] iio: sca3000: switch IRQ handling to " Harshit Mogalapalli
2026-02-03 15:20 ` Andy Shevchenko [this message]
2026-02-03 15:21 ` Andy Shevchenko
2026-02-03 12:20 ` [PATCH v3 next 4/6] iio: sca3000: stop interrupts via devm_add_action_or_reset() Harshit Mogalapalli
2026-02-03 15:24 ` Andy Shevchenko
2026-02-03 15:59 ` Harshit Mogalapalli
2026-02-03 12:20 ` [PATCH v3 next 5/6] iio: sca3000: manage device registration with devm helper Harshit Mogalapalli
2026-02-03 15:23 ` Andy Shevchenko
2026-02-03 12:20 ` [PATCH v3 next 6/6] iio: sca3000: use guard(mutex) to simplify return paths Harshit Mogalapalli
2026-02-03 15:23 ` Andy Shevchenko
2026-02-03 16:01 ` Harshit Mogalapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYISSJLM5CxUXlQv@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andrew.ijano@gmail.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibe.com \
--cc=dlechner@baylibre.com \
--cc=error27@gmail.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox